[#20230] - Make media field initialize itself when a new subform row is added
- Fixed in Code Base
- 10 May 2019
- Medium
- Build: staging
- # 20230
- Diff
- okonomiyaki3000:fix-subform-media
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Subform repeatable has a function fixScripts which calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.
Note: this PR doesn't really fix anything. the media field type already works with repeatable subforms. This just does it in a somewhat better way.
Testing Instructions
Set up a subform containing a media field. There's a subform in the redirect plugin that's simple to use for this purpose.
Open up the form and create new rows. The media field in each new row should function properly.
Expected result
Media field functions normally.
Actual result
Media field functions normally.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.
@HLeithner please a final response
1 year old rtc pr
OK, I'll get right on it
| Labels |
Removed:
J3 Issue
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-10 12:14:45 |
| Closed_By | ⇒ | HLeithner |
thx
I have tested this item✅ successfully on 83f9b21
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20230.