User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Move the inline jQuery dependant code to custom elements/native ES6 javascript
Install this branch, change the default editor to codemirror and check it's functionality (F10 and all the highlighting still works)
Yes
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Front End Plugins |
Labels |
Added:
?
|
Category | JavaScript Repository Front End Plugins | ⇒ | JavaScript Repository Layout Front End Plugins |
Loading failed for the <script> with source “http://localhost:8888/joomla-cms-fields-editor-codemirror/joomla-cms-fields-editor-codemirror/media/vendor/codemirror/lib/codemirror.min.js”.
Looks like domain is added twice
Thanks will check it
Same for addons.js as I tested by adding in index.php
HTMLHelper::_('script', 'media/vendor/codemirror/lib/codemirror.js');
HTMLHelper::_('script', 'media/vendor/codemirror/lib/addons.js');
which still get the error in console but loads the textarea normally.
Also, you still have some debug code in FileLayout.php
@infograf768 @Anu1601CS since I never use subfolders to install any instance of Joomla can you please provide the error messages and a screenshot of the DOM element joomla-editor-codemirror
?
Thanks
@Anu1601CS let me know if latest commit solves the problem
Not working yet. Looks related to the slash
‘src’ attribute of <script> element is not a valid URI: “http://localhost:8888:8888\joomla-cms-fields-editor-codemirror/media/vendor/codemirror/lib/codemirror.min.js”
(can you Update branch?)
@infograf768 can you fetch/pull and try again?
Loading correctly now.
Reminder: You still have some debug code in FileLayout.php
You still have some debug code in FileLayout.php
What do you mean? This PR is not touching any FileLayout.php
@infograf768 that's the debug code for JLayouts, seems related to the PR but it shouldn't be. Do you get the same on the main repo?
Yep, I do. No p.
@Anu1601CS more a css thing: https://stackoverflow.com/a/44954280
Ps the answer is the one below that one I shared (stupid mobile layout)
The buttons will become dropdown similar to tinymce for all editors but cannot be done yet as we don’t have the dropdown custom element yet...
Also the buttons need a new API...
So please hold on here as this is the starting point, there are few more steps to get to the final version
When there is no wysiwyg toolbar the buttons should be at the bottom as they are less important than the editor
Then according to this tinyMCE should get the button (all of them) in the bottom. Seriously now I try to make this consistent in all 3 core editors, but if people think that only tiny should get the xtd-buttons on the top toolbar and the rest should have a different ux/ui then that’s fine for me, let’s keep confusing people. Joomla is well known for this
Well if I were up to me, the TinyMCE toolbar would also be placed at the bottom too.
That said, people don't really switch between editors. They stick with the editor that suites them best. So if they're used to using Codemirror and having XTD buttons that the bottom, leave them there
So if they're used to using Codemirror and having XTD buttons that the bottom, leave them there
In that sense let's revert the left menu to top because that is what ppl are used to?
I will always try to make things consistent, now if others don't care or think that this is a bad idea and it's acceptable to keep broken UX/UI, then fine. Will revert it back the 10 years old approach...
Dimitris, is a simple matter of prioritizing content. We did research on this area ages ago.
The sidebar menu is there because it fixes the issue in J3 where too many components is problematic. It actually fixes something, not just a random thing I initially did for the sake of it.
Please explain why having buttons on the bottom o the editor is a "10 year old approach"...I'm interested.
I guess the best is to have the choice between top and bottom.
Examples:
I always have to scroll in frontend when saving an article because the Save buttons are at the bottom while I would prefer them on top.
Another one is when installing Joomla and choosing to install languages. Instead of having the Buttons on top AND bottom, they are only at the bottom, forcing to scroll that long list when the language you want to install is towards the top.
I always have to scroll in frontend when saving an article because the Save buttons are at the bottom while I would prefer them on top.
Thats the reason in every other software the buttons are always on top
forcing to scroll that long list when the language you want to install is towards the top.
The problem there is that you have a very long page which in fact should be only one multiple selection field, so no scrolling at all.
Anyways, as I said before this is about consistency, but people like to have a messy Joomla so I'll revert these changes, np. Let's keep the bad UX which is the trademark of Joomla
Reverted, enjoy the broken UX
If only we had a UX team who could do some user testing
@infograf768 @Anu1601CS can you please mark your tests here?
Would be good to have some tests here.
Error
Loading failed for the <script> with source “http://localhost/anurag/joomla-cms-fields-editor-codemirror/anurag/joomla-cms-fields-editor-codemirror/media/vendor/codemirror/lib/codemirror.min.js”
Category | JavaScript Repository Front End Plugins Layout | ⇒ | JavaScript Repository Layout |
@Anu1601CS can you confirm that the editor is ok now?
I have tested this item
@dgrammatiko Now it's fine for me.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-11 06:36:03 |
Closed_By | ⇒ | laoneo |
Does not look like working here (installed from your branch):