[#19892] - Fix undefined index: password_clear
- Fixed in Code Base
- 12 Mar 2018
- Medium
- Build: staging
- # 19892
- Diff
- Quy:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #17827.
Summary of Changes
Fix undefined index: password_clear
@schultz-it-solutions Please test.
@zero-24 Please consider for v3.8.6.
Testing Instructions
Go to Users > Manage.
Under Enabled column, click button to enable/block a user.
See php error log file.
Expected result
No notice.
Actual result
PHP Notice: Undefined index: password_clear in \plugins\system\remember\remember.php on line 119
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
See php error log file.
I have tested.
File C:\xampp\apache\logs\error.log
Before patch: PHP Notice: Undefined index: password_clear
After patch: no Notice
Which 'php error log file' do you exactly mean? @Quy
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19892.
You have the right file C:\xampp\php\logs\php_error_log.
I have tested this item
See comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19892.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19892.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19892.
You have the right file C:\xampp\php\logs\php_error_log.
Note @Quy (to avoid misunderstanding)
In the meantime I have found out that one xampp is not the further one. Where I have tested has not an php_error_log file.
So I did an alternative test to be sure.
Before patch:
if ($data['password_clear'] == '')
{
die('test');
return true;
}
Result: Notice = NOK
AND WITH patch
if (empty($data['password_clear']))
{
die('test');
return true;
}
Result: No notice = OK
So I have tested (again) succesfully.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19892.
[EDIT] You can create a new php log file: php error log missing in XAMPP
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-12 22:24:52 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Up to @mbabker to decide if he want to merge this into 3.8.6