[#19889] - [4.0] Permissions now custom element
- Fixed in Code Base
- 3 Apr 2018
- Medium
- Build: 4.0-dev
- # 19889
- Diff
- Anu1601CS:permission
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19427
Summary of Changes
- Move the code to the custom element
- Fix the icon position
Testing Instructions
- Go to Admin Global Configuration and test the permissions
- Change some of the permissions
Expected result
Working as before
Actual result
Working as before
Documentation Changes Required
No
@dgt41 @C-Lodder PR closed in joomla-es6 repo. reopen in main repo.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config JavaScript Repository Layout Unit Tests |
| Labels |
Added:
?
?
|
||
@franz-wohlkoenig can you test this ?
I have tested this item
I applied this path and saw, that the permissions are now in the webcomponent <joomla-field-permissions ..>
I changed some permissions in global configuration. The changed permissions are saved and the inheritance to components works fine. For example, in the global configuration, I set the create permission to denied for the author. In the components com_content I see now that the create = allow is no longer inherited. And I was not able to apply the permisson.
I have created a new user group under registered. The permission have been set correctly (like registered) in the webcomponent <joomla-field-permissions ..>.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19889.
@Anu1601CS i didn't test anymore as my lack of Knowledge generates the Risk of false positive Results.
@franz-wohlkoenig Its ok
@franz-wohlkoenig I do not understand this. I think it's good to have a lot of tests and each test brings something possitive.
It is important that we write down what we have tested, so those who are merge can judge this.
- Go to permissions view.
- Select an option from the dropdown
- A loading/spinner icon should appear whilst the request is being executed
- The label/badge should change to red/green depending on the value selected
- Refresh the page and ensure the value is the same just to make sure it was properly saved (sanity check)
Dropped some extra files. Please test again.
Thanks
@astridx @franz-wohlkoenig Can you please test again?
Thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-03 12:58:06 |
| Closed_By | ⇒ | laoneo |
Thanks. Good work.
@astridx can you test this?
Thanks