Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19484] - [4.0] Update the polyfills, fix other deps

? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
30 Jan 2018

Updates the webcomponents polyfills and also corrects the last update resources as it was wrong since no minification of the css and js was applied

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@wilsonge please merge this!

avatar dgt41 dgt41 - open - 30 Jan 2018
avatar dgt41 dgt41 - change - 30 Jan 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2018
Category ⇒ Administration Templates (admin) JavaScript
avatar astridx
astridx - comment - 30 Jan 2018

With this patch I neither see the warning in the console of the browser nor in the javascript tests. So it is fine.
But I wonder where the file /media/system/js/polyfills/webcomponents/webcomponents-ce.js comes from. Is it a special file for Joomla! ?

avatar dgt41
dgt41 - comment - 30 Jan 2018

@astridx the polyfills come from the repo Joomla-projects/custom-elements(https://github.com/joomla-projects/custom-elements/tree/master/dist/polyfills), check these lines that copy the files from the node_modules folder to the media/system/js/polyfills:

joomla-cms/build/build-modules-js/update.js

Lines 209 to 212 in b6c8828

if (packageName === 'joomla-ui-custom-elements') {
if (fs.existsSync(Path.join(rootPath, 'node_modules/joomla-ui-custom-elements/dist/polyfills'))) {
fsExtra.copySync(Path.join(rootPath, 'node_modules/joomla-ui-custom-elements/dist/polyfills'), Path.join(rootPath, 'media/system/js/polyfills/webcomponents'));
}

avatar astridx
astridx - comment - 30 Jan 2018

@dgt41 Thank you for the link and the explanation.

avatar zero-24
zero-24 - comment - 30 Jan 2018

Ok looks like just one warning is still showing up in drone until he is happy (http://ci.joomla.org/joomla/joomla-cms/2749/5):

+ node_modules/karma/bin/karma start karma.conf.js --single-run
30 01 2018 09:41:06.646:WARN [watcher]: Pattern "/drone/src/github.com/joomla/joomla-cms/media/system/webcomponents/joomla-alert.min.js" does not match any file.

Looks like a file that don't exist anymore?

avatar astridx
astridx - comment - 30 Jan 2018

This file is moved to another folder.
This PR made the correction: #19426
Here you can find the line.

avatar zero-24
zero-24 - comment - 30 Jan 2018

ok so the other PR needs to be merged first and this one updated or a owner hit merge here as this is a required status check ?

avatar wilsonge wilsonge - change - 30 Jan 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-01-30 19:13:42
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 30 Jan 2018
avatar wilsonge wilsonge - merge - 30 Jan 2018

Add a Comment

Login with GitHub to post a comment