[#19485] - Login URL is wrong (doesn't check layout)
- Fixed in Code Base
- 10 May 2019
- Medium
- Build: staging
- # 19485
- Diff
- OctavianC:fix-login-url
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The Legacy router grabs the incorrect item ID if you've created a logout menu item before creating the login menu; that's because it doesn't verify the layout. This patch fixes that. No idea how to fix the Modern routing though.
Testing Instructions
- Make sure SEF is enabled
- Make sure you're using
URL Routingset toLegacyinUsers > Manage > Options > Integration - The order is important: create a new
Users > Logoutmenu item and after that, create a newUsers > Loginmenu item. - Run the following code:
require_once JPATH_SITE.'/components/com_users/helpers/route.php';
var_dump(JRoute::_('index.php?option=com_users&view=login'));
var_dump(UsersHelperRoute::getLoginRoute());
die;Expected result
string(21) "/joomla/index.php/login" string(3) "110"
Actual result
string(21) "/joomla/index.php/logout" string(3) "109"
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
This was on 3.8.3 so no relation with that issue. This seems to have been added way back in #7703 - it added a new layout for the logout menu item, but the routing didn't take it into account (it assumed if it's view=login then it's a login menu item and picks up the Itemid - however, we now have a view=login&layout=logout which is a logout menu item - a little bit of discrepancy here, but everything should be fine after this is merged) :)
OK - thanks for clarifying that
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.
@HLeithner please a final response
1 year old rtc pr
| Labels |
Removed:
J3 Issue
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-10 12:51:49 |
| Closed_By | ⇒ | HLeithner |
thx
IMO there is a little weird configuration after #7703.
Logout view should have own
view=logoutnotindex.php?option=com_users&view=login&layout=logout&task=user.menulogout