? ? Success

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
30 Jan 2018

Summary of Changes

The Legacy router grabs the incorrect item ID if you've created a logout menu item before creating the login menu; that's because it doesn't verify the layout. This patch fixes that. No idea how to fix the Modern routing though.

Testing Instructions

  • Make sure SEF is enabled
  • Make sure you're using URL Routing set to Legacy in Users > Manage > Options > Integration
  • The order is important: create a new Users > Logout menu item and after that, create a new Users > Login menu item.
  • Run the following code:
require_once JPATH_SITE.'/components/com_users/helpers/route.php';
var_dump(JRoute::_('index.php?option=com_users&view=login'));
var_dump(UsersHelperRoute::getLoginRoute());
die;

Expected result

string(21) "/joomla/index.php/login" string(3) "110" 

Actual result

string(21) "/joomla/index.php/logout" string(3) "109" 

Documentation Changes Required

avatar OctavianC OctavianC - open - 30 Jan 2018
avatar OctavianC OctavianC - change - 30 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2018
Category Front End com_users
avatar csthomas
csthomas - comment - 30 Jan 2018

IMO there is a little weird configuration after #7703.
Logout view should have own view=logout not index.php?option=com_users&view=login&layout=logout&task=user.menulogout

avatar brianteeman
brianteeman - comment - 31 Jan 2018

isnt this related to the change being discussed at #19497

avatar OctavianC
OctavianC - comment - 31 Jan 2018

This was on 3.8.3 so no relation with that issue. This seems to have been added way back in #7703 - it added a new layout for the logout menu item, but the routing didn't take it into account (it assumed if it's view=login then it's a login menu item and picks up the Itemid - however, we now have a view=login&layout=logout which is a logout menu item - a little bit of discrepancy here, but everything should be fine after this is merged) :)

avatar brianteeman
brianteeman - comment - 31 Jan 2018

OK - thanks for clarifying that

avatar Quy Quy - test_item - 25 Feb 2018 - Tested successfully
avatar Quy
Quy - comment - 25 Feb 2018

I have tested this item successfully on f655360


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.

avatar viocassel
viocassel - comment - 3 Feb 2019

I have tested this item successfully on f655360


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.

avatar viocassel viocassel - test_item - 3 Feb 2019 - Tested successfully
avatar Quy Quy - change - 3 Feb 2019
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 3 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - edited - 3 Feb 2019
avatar Quy
Quy - comment - 3 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.

avatar Quy
Quy - comment - 3 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19485.

avatar alikon
alikon - comment - 2 May 2019

@HLeithner please a final response

1 year old rtc pr

avatar infograf768 infograf768 - change - 3 May 2019
Labels Removed: J3 Issue
avatar HLeithner HLeithner - change - 10 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-10 12:51:49
Closed_By HLeithner
avatar HLeithner HLeithner - close - 10 May 2019
avatar HLeithner HLeithner - merge - 10 May 2019
avatar HLeithner
HLeithner - comment - 10 May 2019

thx

Add a Comment

Login with GitHub to post a comment