? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
30 Jan 2018

Summary of Changes

Update Tinymce to v4.7.6 and Codemirror to 5.34.0

avatar C-Lodder C-Lodder - open - 30 Jan 2018
avatar C-Lodder C-Lodder - change - 30 Jan 2018
Status New Pending
avatar dgt41
dgt41 - comment - 30 Jan 2018

You need to run 2 more commands:
node build --compilecss
and
node build --compilejs

Right now you just removed all the minified css and js from codemirror

avatar C-Lodder
C-Lodder - comment - 30 Jan 2018

Just goes to show how long I've been out the game

avatar C-Lodder C-Lodder - change - 30 Jan 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2018
Category JavaScript
avatar wilsonge
wilsonge - comment - 30 Jan 2018

This is conflicting with something. Can you please fix :)

avatar C-Lodder
C-Lodder - comment - 31 Jan 2018

@wilsonge done

avatar mokhin-denis
mokhin-denis - comment - 31 Jan 2018

I have tested this item 🔴 unsuccessfully on 8a03285

TinyMCE works,
TinyMCE
but I cant see Codemirror.
Codemirror


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19483.
avatar mokhin-denis mokhin-denis - test_item - 31 Jan 2018 - Tested unsuccessfully
avatar C-Lodder
C-Lodder - comment - 1 Feb 2018

@mokhin-denis was the Codemirror issue there before the update?

avatar mokhin-denis
mokhin-denis - comment - 1 Feb 2018

@C-Lodder I used Testing Joomla! patches, applied this patch and get that results

avatar C-Lodder
C-Lodder - comment - 1 Feb 2018

@mokhin-denis Yes, but was it an issue before the patch?

avatar mokhin-denis
mokhin-denis - comment - 1 Feb 2018

@C-Lodder Should I add an Issue before checking the patch or what? I do not understand

avatar C-Lodder
C-Lodder - comment - 1 Feb 2018

Nevermind, I'll take a look later

avatar C-Lodder C-Lodder - change - 2 Feb 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-02-02 10:41:11
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 2 Feb 2018

Add a Comment

Login with GitHub to post a comment