? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
29 Jan 2018

Pull Request for Issue # #19475

Summary of Changes

Set UA User agent to 'Joomla'

Testing Instructions

  1. Open Extensions->Templates-> Create overrides.
  2. Try any option Module, Component, Layout.
    -> an error will occur.
  3. Apply this patch and open Extensions->Templates-> Create overrides.
  4. Try any option Module, Component, Layout.
    -> override is created.

Expected result

Creates an override of the extension (folder+files)

Actual result

Getting this error :
0 Argument 1 passed to Joomla\CMS\Version::getUserAgent() must be of the type string, null given, called in libraries/src/Factory.php on line 758

Folder is created, no files.

Documentation Changes Required

No

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar astridx astridx - open - 29 Jan 2018
avatar astridx astridx - change - 29 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2018
Category Libraries
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Jan 2018

I have tested this item successfully on a80cc0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19482.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Jan 2018 - Tested successfully
avatar ghazal
ghazal - comment - 30 Jan 2018

I have tested this item successfully on a80cc0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19482.

avatar ghazal ghazal - test_item - 30 Jan 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Jan 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 30 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-30 21:23:08
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 30 Jan 2018
avatar wilsonge wilsonge - merge - 30 Jan 2018
avatar wilsonge
wilsonge - comment - 30 Jan 2018

Thanks :)

Add a Comment

Login with GitHub to post a comment