[#18958] - [4.0] Fix issues when people don't enter the right information in the installer
- Fixed in Code Base
- 9 May 2018
- Medium
- Build: 4.0-dev
- # 18958
- Diff
- wilsonge:fix-installation-checker
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18557 .
Summary of Changes
Changes how json issues are returned so everything in the CMS runs through the main application rather than echo'ing json and trying to run $app->close which we sometimes do in core to work around bad plugins - we don't have these in the installer and it makes the logic much clearer
Fixes how responses from dbcheck are handled - there is now an error shown and installation stopped when things go wrong in the installer
Note the UX isn't great because the error is displayed at the top of the page and you have to scroll all the way up to the top to see that. But I'm not a frontender - so I'll leave that for a subsequent PR from @ciar4n or @C-Lodder - this at least means things are functional
// cc @laoneo as you wrote some of this JSON error handling
Testing Instructions
Enter incorrect database credentials into the installer
Expected result
It bails
Actual result
Configuration file is written and you have to remove configuration.php to ever do anything again.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation JavaScript |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have the same behavior with and without the patch.
Can you try again please?
I have tested this item
Works now, except the UI which is not rendered correctly as pointed already out in the pr description.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18958.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18958.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-09 14:51:17 |
| Closed_By | ⇒ | laoneo |
Thanks!
Thanks guys :)
I have tested this item? unsuccessfully on 1c70e52
Installation of 18958.zip using wrong Database-Information (wrong user and wrong Password) got:
No Way found to go a Step return an use correct Informations.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18958.