? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
2 Dec 2017

Pull Request for Issue #18866

Summary of Changes

This PR removed every reference to the bootstrap_size field for modules

avatar C-Lodder C-Lodder - open - 2 Dec 2017
avatar C-Lodder C-Lodder - change - 2 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Dec 2017
Category Administration com_modules Language & Strings Templates (admin) Front End com_config SQL Installation Postgresql Plugins Templates (site)
avatar C-Lodder C-Lodder - change - 2 Dec 2017
Labels Added: ? ?
avatar N6REJ
N6REJ - comment - 2 Dec 2017

removing the param I think is the wrong direction. The whole purpose was to give the user flexibility in sizing the module. Now you've not only removed that ability but forced them into a fixed state. i.e. we're back into 1.5 days.

avatar brianteeman
brianteeman - comment - 2 Dec 2017

Please read all the comments @N6REJ

avatar C-Lodder
C-Lodder - comment - 2 Dec 2017

@N6REJ The page structure has absolutely no association with Bootstrap. We do NOT use Bootstrap column classes anymore for Cassiopeia. We are utilising CSS Grid which may be a "1.5 days" approach to you, but a 2017 approach to all UI developers

avatar N6REJ
N6REJ - comment - 5 Dec 2017

@C-Lodder you state that put yet you put the column class in!

<div class="col-md-6">
    <div class="myclass"></div>
</div>

I can only go by what you say/show/do.
While the name / function needs to be changed, the PURPOSE of it is valid.
grid does have column size & number ability just like bs does with col- so why not provide that ability EASILY.

avatar mbabker
mbabker - comment - 6 Dec 2017

The UI options are inherently limited without templates putting in their own parameters. Do we offer params mapping to just col-X or do we offer params for col-sm-X, col-md-X, col-lg-X, and col-xl-X as well? What if the UI framework used by the template doesn't use a markup driven grid like Bootstraps? What if its breakpoints don't align with those of Bootstrap (in terms of number and resolution)?

Long and short, the only reliable way to offer these sizing parameters is to continue to use HTML driven grids. Those have issues and limitations that are addressed by the newer CSS Grid implementations and it has been elected to focus on adapting our technology toward newer and preferred trends, not sticking to inherently broken and limited options.

avatar C-Lodder
C-Lodder - comment - 6 Dec 2017

@N6REJ - The backend and frontend templates are 2 completely different things. In the FE template we're using CSS grid for the page structure, whereas in Atum we're still using BS4.

you state that put yet you put the column class in!

As you can see by my actual code changes, I do not use col-md-6 in the Cassiopeia modChrome and clearly state in my comment above that I'm referring to Cassiopeia, not Atum.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Dec 2017

@C-Lodder can you please give Test Instructions in your first Comment so Tester are sure where to look?

avatar N6REJ
N6REJ - comment - 9 Dec 2017

@mbabker I see what you mean. Is there anyway to allow the flexibility of module size param and non-rigid classes also without resorting to forcing the users to create css sizing?

avatar C-Lodder
C-Lodder - comment - 9 Dec 2017

Franz, this is only to remove a parameter. Just a code revoew will do

avatar mbabker
mbabker - comment - 9 Dec 2017

Is there anyway to allow the flexibility of module size param and non-rigid classes also without resorting to forcing the users to create css sizing?

Templates use the existing plugin events to extend the module edit form then use their extended parameters in the module chrome. An option that has always existed so that there isn't a reliance on trying to map a select list offering a mapping to BS2 spanX classes to an inflexible grid system.

avatar N6REJ
N6REJ - comment - 10 Dec 2017

@mbabker

Templates use the existing plugin events to extend the module edit form then use their extended parameters in the module chrome

Anywhere explaining the details / how's of that anywhere?

avatar C-Lodder
C-Lodder - comment - 16 Dec 2017

@Quy done

avatar dgt41
dgt41 - comment - 16 Dec 2017

@wilsonge merge?

avatar C-Lodder C-Lodder - change - 2 Feb 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-02-02 10:45:24
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 2 Feb 2018
avatar htmgarcia
htmgarcia - comment - 8 Aug 2018

@wilsonge @brianteeman are we removing the Bootstrap size parameter in modules? With the use of CSS Grid make no sense to keep a setting that is bootstrap related.

Add a Comment

Login with GitHub to post a comment