[#18959] - [4.0] Rewrite indexer in vanilla Javascript
- Fixed in Code Base
- 10 Dec 2017
- Medium
- Build: 4.0-dev
- Easy Test
- # 18959
- Diff
- C-Lodder:indexer
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove all jQuery from indexer.js (apart from 1 line which I'm not sure about)
Testing Instructions
Ensure the smart search indexer still works.
There is an open issue (#18861) by which the index doesn't work with sample data on a multilang site. So testing can be done on a installation with no sample data.
@franz-wohlkoenig Can you check if this solves the issue you raised? Don't think it will but just incase.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
| Category | JavaScript | ⇒ | Administration com_finder JavaScript |
Errors fixed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18959.
| Easy | No | ⇒ | Yes |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-10 15:52:07 |
| Closed_By | ⇒ | wilsonge |
Hmm ok same error as before. I see you have debug enabled so I'll test tonight
Also when indexing or simply displaying the Manager I get:
[13-Dec-2017 12:01:10 Europe/Berlin] PHP Notice: Undefined variable: name in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_finder/Field/ContentmapField.php on line 99
[13-Dec-2017 12:01:10 Europe/Berlin] PHP Notice: Undefined variable: name in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_finder/Field/ContentmapField.php on line 110
[13-Dec-2017 12:01:10 Europe/Berlin] PHP Notice: Undefined variable: name in /Applications/MAMP/htdocs/installmulti/joomla40/administrator/components/com_finder/Field/ContentmapField.php on line 115
@infograf768 Please open a new issue.
I can see why this is happening but I have no idea what the default value for $name should be in that file as I've never used com_fields before
com_finder you mean I guess .
Oops, yes.
I compared to J3.x and the files looks like it would have the same problem there too. $name isn't defined before the if/else statement
indeed, although I don't remember getting the error in 3.x
can test in a few Days (reminder #18861)