RTC

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Oct 2017

PR for #17938

Thanks to @GCLW for the code and his patience

Test instructions

in \administrator\components\com_content\models\forms\article.xml
add the following two lines to the "created" field

timeformat="12" format="%Y-%m-%d %H:%M:%S"
As you set the time in the calendar observe the time in the field.

  1. Set the time to 4pm and the field shows 16:00
  2. Now set the time to 12am and the field will show 12:00

This is the bug. It should show 00:00

Apply this PR,clear cache, and it will behave correctly as in the video below

after PR

clock

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2017
Category JavaScript
avatar brianteeman brianteeman - open - 4 Oct 2017
avatar brianteeman brianteeman - change - 4 Oct 2017
Status New Pending
avatar ggppdk
ggppdk - comment - 5 Oct 2017

if i popup calendar in the hour, minute field if i select

10:00 am it shows 10:00
11:00 am it shows 11:00
12:00 am it shows 00:00

10:00 pm it shows 22:00
11:00 pm it shows 23:00
12:00 pm it shows 12:00

i do not say that this change is wrong
it seems correct

but there is an ux problem, that the hours selector 12 is placed after 11,
thus user selecting would expected it to show something bigger right ?

@dgt41
maybe replace 12 with 00 when calendar is shown in am / pm format , and of course place 00 on top of the hours drop down selector ?

avatar brianteeman
brianteeman - comment - 5 Oct 2017

That is beyond the scope of this pr

avatar GCLW
GCLW - comment - 5 Oct 2017

@ggppdk
I think it would be wise to keep the hour selector containing only 1-12 in when using the timeformat=12 attribute. Only when the timeformat=24 is used should there be a "00" in the selector. There is no UX problem. it is a logical range 01-12 that stays consistent, the user only selects if it is AM or PM.

I think you are trying to force the logic that if someone were to select 11 PM and changed their mind to make it midnight they would just bump up the 11 to a 12, which effectively now makes it 12 PM (noon). That is not a UX problem. That is 100% user error.

The correct logic by a user would be "I have it set to 11:30pm, but I need to change it to midnight. The user would then change the 11 to a 12 and change PM to AM. That is the user logic.

avatar brianteeman
brianteeman - comment - 5 Oct 2017

it is out of scope for this Pr anyway

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 28 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Oct 2017

I have tested this item successfully on fae7637


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18240.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Nov 2017
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

marked as "Easy test".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18240.

avatar FPerisa FPerisa - test_item - 15 Nov 2017 - Tested successfully
avatar FPerisa
FPerisa - comment - 15 Nov 2017

I have tested this item successfully on fae7637


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18240.

avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Nov 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 18 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-18 15:52:39
Closed_By mbabker
Labels Added: RTC
avatar mbabker mbabker - close - 18 Nov 2017
avatar mbabker mbabker - merge - 18 Nov 2017

Add a Comment

Login with GitHub to post a comment