[#18239] - [com_fields] Color plugin - invalid markup
- Fixed in Code Base
- 21 Dec 2017
- Medium
- Build: staging
- Easy Test
- # 18239
- Diff
- brianteeman:color-field
User tests: Successful: Unsuccessful:
Create a color field for content and set it to be required
Open an article to edit and view the source
You will see
<input type="text" name="jform[com_fields][colour]" id="jform_com_fields_colour" value="none" placeholder="#rrggbb" class="minicolors required" data-position="default" data-control="hue"1 data-format="hex" data-validate="color"/>
Note thedata-control="hue"1 the 1 should not be there
This PR resolves that
PR for #18067
joomla-cms-bot
- | Category | ⇒ | Layout |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18239.
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
RTC after two successful tests.
Err, something doesn't seem right here. This PR removes the ability to set a color field as readonly or required.
I dont think readonly was there before - but required does indeed appear to be broken - please remove rtc and I will look at it later
| Status | Ready to Commit | ⇒ | Pending |
Then something's not right, you're removing $readonly and $required variables which tells me that neither of those attributes should be in the resulting output unless they're being attached to something else, which seems wrong too. Either way I can look more later too, about to leave for work.
Thanks - tbh the code in the plugin is a bit of a mess and there is JS involved as well
| Status | Pending | ⇒ | Needs Review |
| Category | Layout | ⇒ | com_fields Layout |
| Title |
|
||||||
| Category | Layout com_fields | ⇒ | Layout |
There isn't a readonly setting for custom color field.
validate.js dynamically adds the aria-required and required attributes so it is safe to remove $required.
@brianteeman can you please look at comment of @Quy above?
@brianteeman Let's revert $readonly since $required is the main issue.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18239.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18239.
| Status | Needs Review | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-21 00:12:00 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 93ef58c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18239.