? ? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
15 Jun 2017

Pull Request for Issue #15305 and altornative to #15529 .

Summary of Changes

Fix the path for the ajax-loader.gif

Testing Instructions

Please see #15305 and #15529

Documentation Changes Required

none

avatar Fedik Fedik - open - 15 Jun 2017
avatar Fedik Fedik - change - 15 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2017
Category JavaScript
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Jun 2017

Tested with and -out Menu "Create Article" and with and -out PR got no Error in Console>JS.

System information

3.7.3-dev (latest nightly build)
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar Quy
Quy - comment - 15 Jun 2017

@franz-wohlkoenig Without the pr, I get the error when editing an article in the frontend.

avatar infograf768
infograf768 - comment - 16 Jun 2017

Firefox
I do not get the error either.
Is the ajax-loader.gif supposed to be displayed when saving such an article?
The only error I get is:
Empty string passed to getElementById().jquery.min.js:2:24932

avatar infograf768 infograf768 - test_item - 16 Jun 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 16 Jun 2017

I have tested this item successfully on 502183a

Safari displays the error. Patch solves the issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16701.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2017

I have tested this item successfully on 502183a

Didn't get Error in Safari on Mac, but on Chrome.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16701.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 21 Jun 2017
Milestone Added:
avatar rdeutz rdeutz - change - 21 Jun 2017
Milestone Added:
avatar rdeutz rdeutz - change - 11 Jul 2017
Milestone Added:
avatar rdeutz rdeutz - change - 11 Jul 2017
Milestone Removed:
avatar mbabker
mbabker - comment - 19 Jul 2017

Merge conflicts need to be resolved.

avatar Fedik Fedik - change - 19 Jul 2017
Labels Added: Conflicting Files
avatar mbabker mbabker - change - 25 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-25 23:43:15
Closed_By mbabker
avatar mbabker mbabker - close - 25 Jul 2017
avatar mbabker mbabker - merge - 25 Jul 2017

Add a Comment

Login with GitHub to post a comment