? Failure

User tests: Successful: Unsuccessful:

avatar yvesh
yvesh
15 Jun 2017

Pull Request for Issue #16682 .

Summary of Changes

Fixes in the folder structure for the namespaced MVC

Testing Instructions

Check that com_config is working in frontend and backend

Expected result

com_config is working on all operating systems

Actual result

com_config is not working on Windows / Mac

Documentation Changes Required

avatar yvesh yvesh - open - 15 Jun 2017
avatar yvesh yvesh - change - 15 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2017
Category Administration com_config Front End
avatar laoneo
laoneo - comment - 15 Jun 2017

Nice one! Good work.

avatar infograf768
infograf768 - comment - 15 Jun 2017

Confused.
The files that were not indexed in the original Issue are not deleted in this patch when I apply it in Eclipse.
The new folder Field is not created either.

I get this:
screen shot 2017-06-15 at 11 39 13

avatar yvesh
yvesh - comment - 15 Jun 2017

@infograf768 hmph looks like git is not able to update that correctly :( when you do a clean clone is it working?

avatar infograf768
infograf768 - comment - 15 Jun 2017

Cloning from your repo would be useless I guess.
I guess I better wait this is merged (if someone can test it first) and then see if I can update from upstream branch correctly. Otherwise I would have to re-create a project on my workspace for Eclipse.

avatar Bakual
Bakual - comment - 15 Jun 2017

It will be interesting anyway what happens after this is merged when updating using the Joomla Update component.

avatar yvesh
yvesh - comment - 15 Jun 2017

@Bakual yep, we need an pre-fllight script in many areas.. it's not only com_config :/

avatar wilsonge wilsonge - change - 15 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-15 11:37:40
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Jun 2017
avatar wilsonge wilsonge - merge - 15 Jun 2017
avatar wilsonge
wilsonge - comment - 15 Jun 2017

There's definitely an update issue to solve. But let's get this merged so people downloading fresh copies of J4 can actually run things

avatar infograf768
infograf768 - comment - 15 Jun 2017

FYI, I had to reclone my repo here. Could not get it to update through eclipse/egit

avatar infograf768
infograf768 - comment - 15 Jun 2017

and this #16709

avatar Bakual
Bakual - comment - 15 Jun 2017

SmartGit does show it funny:
image
Renaming the folder manually fixed it.

Add a Comment

Login with GitHub to post a comment