Feeling Lucky
?
[#16702] - TinyMCE parameters: displaying background color icon correctly
- Fixed in Code Base
- 19 Jun 2017
- Medium
- Build: staging
- # 16702
- Diff
- infograf768:tiny_icons
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15370
Summary of Changes
The plugin loads the skin.min.css where we have
i.mce-i-backcolor {
background: #bbb none repeat scroll 0 0;
text-shadow: none;
}
which can't be loaded as the code uses <span>
changed to <i>
Testing Instructions
Edit the TinyMCE plugin
Before patch we get
After patch we have
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript External Library |
franz-wohlkoenig
- comment
- 15 Jun 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16702.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 15 Jun 2017
RTC after two successful tests.
rdeutz
- comment
- 15 Jun 2017
I think is the better choice seems wrong to me, couldn't we add css to cover the use case?
Fedik
- comment
- 15 Jun 2017
@rdeutz I think the fix made by @infograf768 is correct,
because tinymce-builder.js tries to imitate the TinyMCE markup to display the toolbar in the same way
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-19 07:24:05 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 64b605a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16702.