[#16036] - [4.0] Save sidebar state using localStorage
- Fixed in Code Base
- 29 May 2017
- Medium
- Build: 4.0-dev
- # 16036
- Diff
- C-Lodder:sidebar-ls
User tests: Successful: Unsuccessful:
Pull Request for Issue #15892
Summary of Changes
This PR adds the use of localStorage to save the state of the sidebar (open/closed). Upon page refresh it wil automatically open or close the sidebar based on the state it was in before.
Testing Instructions
1.
- Apply patch (sidebar should be open)
2.
- Close the sidebar
- Refresh the page
- Sidebar should stay closed
3.
- Open the sidebar
- Refresh the page
- Sidebar should stay open
@dgt41 I've added the test to see if localStorage can be used in the core.js, so you can use this from now on. Just do if (Joomla.localStorageEnabled()) { ... }
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration Templates (admin) |
Yup, but if the user has it disabled on their browser for some reason, then this is just a sanity check to prevent any console errors, which may then stop something else from working.
brings up a good point though - do we have a list of supported MOBILE browsers
@brianteeman no AFAIK
@brianteeman - You're not going to want to keep the sidebar open on mobile as it will take up most of the screen.
I have tested this item
With this PR certain views end up with an empty space at the side
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16036.
which views?
before pr
after pr
Will fix tomorrow morning
| Labels |
Added:
?
|
||
@brianteeman - Fixed the edit views. Would you mind retesting please?
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-29 09:02:45 |
| Closed_By | ⇒ | wilsonge |
@C-Lodder do we need this check?
Looking at https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage it should be available for all supported browsers in J4