[#16035] - If view "not found" then send 404 Not Found, not 500 Internal Server Error
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 16035
- Diff
- PhilETaylor:503to404
User tests: Successful: Unsuccessful:
Currently if you go to a nonexisting faked url with an invalid view you get a 500 Internal Server Status response with view not found message
It would be more appropriate to give a 404 Not Found status for a view not found error.
http://joomla-cms/index.php?option=com_content&view=nonsuch
We already do this if SEF enabled (E.g.https://www.joomla.org/index.php?option=com_content&view=nonsuch gives a 404), there is no reason (that i can see) that we would not also do it if SEF was not enabled .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
tested successfully on the components that threw a 500
note that some do not such as com_config which threw a 200
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16035.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
note that some do not such as com_config which threw a 200
com_config doesn't use "legacy" MVC (but "new" MVC) so it's gonna do something weird. There aren't any other components using new MVC - so any other examples are actually pretty important
Is Github "approving" the new "joomla human test result" ? or is it some badge of honour Im collecting now? :-)
@brianteeman indeed. I mean it's still a bug - but it wouldn't be covered by this PR. What other components are affected though?
@PhilETaylor it's just code review - but doesn't substitute for a proper test on a site that we use as one of the merge criteria
No. it's a github specific string
And com_ajax has no views so I guess that kinda makes sense. I guess if we don't trigger a module or plugin we should probably throw a 404 there too.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:23:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on a5f60a7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16035.