? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
15 May 2017

Pull Request for Issue #16025.

Summary of Changes

Removes the warning
Warning: Cannot declare class JToolBar, because the name is already in use in /j4/libraries/loader.php on line 769

avatar laoneo laoneo - open - 15 May 2017
avatar laoneo laoneo - change - 15 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2017
Category Libraries
avatar C-Lodder
C-Lodder - comment - 15 May 2017

Doesn't this need to go against the 3.8 branch?

avatar mbabker
mbabker - comment - 15 May 2017

Maybe? At a first glance I'd say 3e4002c did something to change the behavior. But if it's working fine on 3.8 and not 4.0 then something else goofy is happening behind the scenes.

avatar laoneo
laoneo - comment - 15 May 2017

The biggest diff is that on 3.8 there are JToolBarcalls while on 4.0 there are only JToolbar. Beside that the branches should be even.

avatar C-Lodder
C-Lodder - comment - 15 May 2017

@mbabker It's not being caused by this is it? 3e4002c#diff-9167b70f777bcada95fed26c314bb75fR249

avatar mbabker
mbabker - comment - 15 May 2017

That's what I was thinking but it seems hella weird if it's working on the 3.8 branch right now but not 4.0.

avatar wilsonge wilsonge - close - 15 May 2017
avatar wilsonge wilsonge - merge - 15 May 2017
avatar wilsonge wilsonge - change - 15 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-15 16:58:33
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 15 May 2017

Run with it for now. But it's very odd

Add a Comment

Login with GitHub to post a comment