[#15837] - [4.0] Replace element-invisible class with sr-only
- Fixed in Code Base
- 8 May 2017
- Medium
- Build: 4.0-dev
- # 15837
- Diff
- C-Lodder:sr-only
User tests: Successful: Unsuccessful:
Pull Request for Issue #15832
Summary of Changes
Replace all element-invisible classes with sr-only.
Keep the element-invisible class in the template SCSS files but update to use the same styling as sr-only for B/C
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_joomlaupdate com_languages com_menus com_newsfeeds com_search Templates (admin) Front End com_tags Layout Libraries JavaScript Modules |
We aren't doing full backwards compatibility. But we're mapping limited numbers of classes to try and make dev work easier
thanks for answering
Maybe I misunderstand but if you are keeping the element-invisible css for b/c don't you also have to ensure that they javascript that was targeting that class still works as well. This PR changes all the js to only target the sr-only class.
So in summary while you are trying to keep backwards compatibility for anyone using the element-invisible class its only partially b/c because of the changing javascript.
I have added a documentation required tag so this change can be added to the docs
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-08 10:16:26 |
| Closed_By | ⇒ | wilsonge |
Thanks Brian and also thanks Charlie :)
I thought we weren't maintaining CSA ba kwarsa compatibility?