?
avatar zstergios
zstergios
5 May 2017

Steps to reproduce the issue

libraries\vendor\simplepie\simplepie\library
Version is outofdate. Newer versions all compatible with PHP7 and provide many fixes

Expected result

Version 1.5
https://github.com/simplepie/simplepie/releases/tag/1.5

Actual result

Version 1.3.1

System information (as much as possible)

Joomla 3.7
PHP 7

Additional comments

I suggest to update the package with latest simplepie version.
Also I suggest to make it package/library extension to able to auto-update each time is required or to include it only on pages that requires that

avatar zstergios zstergios - open - 5 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 May 2017
avatar zstergios
zstergios - comment - 5 May 2017

Also seems simplePie library is auto loaded. This should not be happened, only if extension has requested to load
if(defined('SIMPLEPIE_VERSION')) echo "SIMPLEPIE IS AUTO-LOADED";

avatar brianteeman
brianteeman - comment - 5 May 2017

See the component from @wilsonge here #10835 (comment) I dont know if he ever did check it

avatar zstergios zstergios - edited - 5 May 2017
avatar zstergios
zstergios - comment - 5 May 2017

Sorry for that! I searched before on https://issues.joomla.org.

avatar mbabker
mbabker - comment - 5 May 2017

Also seems simplePie library is auto loaded.

Everything in libraries/vendor is hooked up to Composer's autoloader, which depending on the package configuration will either manually load files when that's included or register mapping definitions so that classes can be loaded. Just because something's registered into the autoloader doesn't mean the entire package is actually loaded into memory.

avatar zstergios
zstergios - comment - 5 May 2017

Thanks!

avatar zstergios zstergios - change - 5 May 2017
Title
SimplePie v1.5
SimplePie v1.5 + autoload
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-05-05 14:22:35
Closed_By zstergios
avatar zstergios zstergios - close - 5 May 2017
avatar brianteeman
brianteeman - comment - 5 May 2017

i am reopening this as its still a valid question for @wilsonge if simplepie can be updated or not

avatar brianteeman brianteeman - change - 5 May 2017
Status Closed New
Closed_Date 2017-05-05 14:22:35
Closed_By zstergios
avatar brianteeman brianteeman - reopen - 5 May 2017
avatar wilsonge
wilsonge - comment - 5 May 2017

I haven't had time to look into it. We have no examples in core, and I just don't have time to do a full code review inspection at the moment :/

For what little it's worth Wordpress haven't decided to go beyond 1.3.1 (their corresponding tracker has been open https://core.trac.wordpress.org/ticket/36669)

Honestly I'd just update it through composer and try it. Worst case is in a subsequent patch we may have to revert back

avatar zstergios
zstergios - comment - 5 May 2017

Ι'm the developer of "Ultimate Feed Display", I have replaced the folder
libraries\vendor\simplepie\simplepie\library with the new folder of version 1.5

I made some tests (through my mod) and I did not faced any crash or misbehavior.
I don't know how to test it further but seems OK to me.

avatar brianteeman
brianteeman - comment - 5 May 2017

OK well please submit a PR to update the library

You should be aware that this library is not included in Joomla 4

avatar franz-wohlkoenig franz-wohlkoenig - change - 6 May 2017
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 May 2017
Category External Library
avatar brianteeman
brianteeman - comment - 14 May 2017

@zstergios I am closing this at this time. If you want to submit a PR to update simplepie then great

avatar brianteeman brianteeman - change - 14 May 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-05-14 14:16:54
Closed_By brianteeman
avatar brianteeman brianteeman - close - 14 May 2017

Add a Comment

Login with GitHub to post a comment