[#15836] - Allow use of Redis over sock and not TCP Socket
- Closed
- 13 Aug 2017
- Medium
- Build: staging
- # 15836
- Diff
- PhilETaylor:joomla-cms-15822
User tests: Successful: Unsuccessful:
Pull Request for Issue #15822.
Summary of Changes
Improve tooltip to show what values should be accepted
Allow Joomla to connect correctly to Redis that is using sock and not TCP
LANGUAGE FILE CHANGE (no idea how to propagate that to translators)
Testing Instructions
Set up redis.conf with port 0 and listening on a sock
port 0
unixsocket /tmp/redis.sock
restart redis
Joomla global Config as such:
Expected result
no matter what port you enter, joomla will ignore it, as long as the sock file is correct, Joomla can connect and cache
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
Tested and working as expected on my side.
@steelAXIS can i alter your Test as successfully at Issue Tracker?
@franz-wohlkoenig sure go ahead.
done, thanks.
@PhilETaylor can you resolve the conflicts please?
@brianteeman This is not a conflict. This is 10 tonnes of Joomla progressing (libraries/joomla/cache doesnt exist any more, lots of refactoring of libraries and vendors) while a PR remains unmerged. This PR is no longer fit for use.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-13 20:56:15 |
| Closed_By | ⇒ | PhilETaylor |
Phil it seriously should just be a git merge upstream staging and done. The vast majority of PRs touching moved libraries files have been easily sync'd with a merge, I've seen very few merge conflicts beyond the file rename.
(And I wrote this before realizing the new PR was there, but just for general reference...)
i was/am in bed and exhausted and too sleepy to dig :)
You cannot merge changes to a file that no longer exists though right ? This is what happened with this PR.
As long as the file was moved in a git rename operation then merging the upstream branch should track that and attempt to migrate your changes to the new file path.
You're screwed though if git tracks it as deleting the old file and creating a new file (git proper, not how GitHub displays things).
Don't worry about that.