[#14593] - Drop eval from compressed file
- Fixed in Code Base
- 14 Mar 2017
- Medium
- Build: staging
- # 14593
- Diff
- dgt41:patch-12
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The file overrider.min.js is badly compressed and is using eval(). Don't use eval(). Never!
The file is minified from the source (using https://jscompress.com), nothing fancy here, can go on review
Documentation Changes Required
None, but there should be a rule that minified scripts should not use eval function
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
(note that json2.js used in com_joomlaupdate uses eval - it is intended to use eval - but as this file is only needed for ie8 support it can probably be dropped in j4)
I did a PR and update it that to jason3 few hours ago
Great minds think alike - didnt see that PR though?
ah - thats because you once again have a pr doing multiple things. One PR per task. It makes it so much easier to test.
In this particular case it makes sense to pack all the changes in one PR, as the tester will have to verify that the update still works (all the views files updated are engaged). So breaking it down to minor changes will mean multiple unneeded tests. This is an exemption to the rule, which I agree PRs need to be singular task oriented...
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-14 10:53:05 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
agree about not using eval