Feeling Lucky
?
[#14594] - [4.0] More external scripts to vendor folder
- Closed
- 22 Jul 2017
- Medium
- Build: 4.0-dev
- # 14594
- Diff
- dgt41:+++++++++++++++++more_ext_scripts
- Failure continuous-integration/drone/pr the build failed Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR is clearing up com_joomlaupdate javascript:
- Update json2.js to json3.js and use the vendor folder and the grunt script to auto update it
- Update aes-js and use the vendor folder and the grunt script to auto update it
Move all inline script declarations to their relative javascript files.
Testing Instructions
- Install 4.0
- apply this patch
- go to the options and set this: https://update.joomla.org/core/nightlies/next_major_list.xml as your custom update URL
Expected result
Everything still works
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
zero-24
- comment
- 14 Mar 2017
No Problem. I just want to help out here
| Category | JavaScript Administration com_joomlaupdate | ⇒ | JavaScript Repository Administration com_joomlaupdate |
wilsonge
- comment
- 20 May 2017
This needs actual tests. I don't know how these dependencies interact with the main updater well, so I'm not comfortable merging without actual tests
alikon
- comment
- 3 Jun 2017
reinstall package doesn't work
brianteeman
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-22 20:03:17 |
| Closed_By | ⇒ | dgt41 |
Just use reinstall with this: #14540 or similiar Patch applyed?
Also Upload and install a update package should trigger that path.