[#12512] - Remove error message from keepalive behaviour
- Fixed in Code Base
- 7 Nov 2016
- Medium
- Build: staging
- # 12512
- Diff
- andrepereiradasilva:patch-15
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Simple change.
In #8545 i made javascript send an error message on keepalive ajax behaviour failure.
But now when the computer goes to hibernation or something we get some error messages in the site because of this.
So this PR removes those error message, ie, returns to the older behaviour in this aspect, ie, fails silently.
Testing Instructions
Code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
Ah so thats why I saw that - wondered what it was
On 1 November 2016 at 12:48, andrepereiradasilva notifications@github.com
wrote:
plese check this or else the sites will have messages like this when the
computer goes to standby/hibernation (or somehting like that)[image: image]
https://cloud.githubusercontent.com/assets/9630530/19890268/77671db8-a031-11e6-8f9d-972a6209f44d.png—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12512 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8f_tH6E-TB-aalyvy4bf-SioRZ0Iks5q5zU1gaJpZM4Kd4c5
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
@brianteeman when you have time please check this. We don't want this message in all sites ...
In the admin I am seeing this message in the scenario you describe
An error has occurred while fetching the JSON data: HTTP 403 status code. You are not authorised to view this resource.
Is this the same issue? Does this fix it as well?
yes i think so
OK - I will test it tonight
grrh - I cant replicate the issue now ;(
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12512.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12512.
we did not have the message here before (for keep alive), we do not need it now
or apply patch (leave it applied for two or 3 days and check no more message)
I will try that
So far so good
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12512.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12512.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- | Milestone |
Added: |
||
| Labels |
Added:
?
|
||
rdeutz
- 
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-07 16:22:41 |
| Closed_By | ⇒ | rdeutz |
plese check this or else the sites will have messages like this when the computer goes to standby/hibernation (or somehting like that)