[#12511] - Fix Showon feature for fields in a subform field, AND speadup showon code
- Fixed in Code Base
- 23 Oct 2016
- Medium
- Build: staging
- # 12511
- Diff
- Fedik:showon-subform
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The pull fix Showon feature for a fields in the subform field, #11548 .
Also here is the perfomance optimisation.
Perfomance of showon feature in global configuration:
before 134ms
after 59ms
Testing Instructions
Create subform field (example in module Custom):
<field name="items" type="subform" formsource="modules/mod_custom/test.xml"
multiple="true" label="Subform Field" />Create a form (modules/mod_custom/test.xml) for the subform field, that contain showon feature:
<?xml version="1.0" encoding="UTF-8"?>
<form>
<field name="type" type="list" default="0" label="Type" >
<option value="0">Small</option>
<option value="1">Medium</option>
<option value="2">Large</option>
</field>
<field name="something" type="text"
label="Show when Type=Large" showon="type:2" />
</form>or even use XML from #8524 (that even better for test, but without the radio button with "btn-group-yesno" as it still broken).
And make sure that showone feature works.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
can't we drop jQuery here and use vannila js?
it can be complicated here, for now I would leave it as it is
i think this needs to go to 3.7.x branch
it is bugfix from some point of view
I leave it for maintainers to decide
styling of the radio button with "btn-group-yesno" it another issue, not related to showon
ignore it here
Ah I see. Hopefully this fix will be incorporated in the next 3.6.4
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12511.
@zero-24 Done! Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12511.
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12511.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12511.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-23 15:33:22 |
| Closed_By | ⇒ | zero-24 |
Thanks merged
| Labels |
Removed:
?
|
||
@Fedik i think this needs to go to 3.7.x branch.
Also, since 3.7.x already accepts js polyfills, can't we drop jQuery here and use vannila js ?
i mean IIRC jQuery is only used in cms.js for this showon.
But also i think that can be another PR, since this intend to fix an issue too.