[#12513] - [3.7.x] Update js polyfills to 3.13.0
- Fixed in Code Base
- 22 Oct 2016
- Medium
- Build: 3.7.x
- # 12513
- Diff
- andrepereiradasilva:patch-21
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
In 3.7.x we have the new polyfill behavior to load js polyfills for old browsers.
When #11686 was made we needed to make a custom change for DomContentLoaded polyfill to work (see the PR for details).
Meanwhile i made a PR in the polyfill repo Financial-Times/polyfill-service#862 to solve the issue. Was accepted and it's integrated in version 3.1.30 (current live version) of the polyfill service.
So this PR removes that custom change to use the 3º party library without any custom changes and also updates the polyfills from 3.9.2 to 3.13.0 (current live version).
More info https://cdn.polyfill.io/v2/docs/
Testing Instructions
After patch. Js polyfills (event, classlist) still work.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
Tested ok as well!
@andrepereiradasilva what is the npm package for the polyfiills (so I can add them to the automation in j4)?
@andrepereiradasilva and @Fedik
Try clearing your browser caches there. I made a couple of changes in the last few days to stop it from saving a test without a commit SHA and found one of the JavaScript paths wasn't including the SHA in its processing (fixed now).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12513.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12513.
| Status | Pending | ⇒ | Ready to Commit |
RTC
Thanks @andrepereiradasilva
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
I merge now for 3.7 Thanks!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-22 19:46:28 |
| Closed_By | ⇒ | zero-24 |
thanks all!
| Labels |
Removed:
?
|
||
Congrats and good stuff on your pr being merged upstream
test is good,
but cannot set it "good" via issues.joomla.org, got strange error:
