[#12345] - Fixing JavaScript tests in Firefox 49 and on drone.io
- Fixed in Code Base
- 7 Oct 2016
- Medium
- Build: staging
- # 12345
- Diff
- yvesh:javascriptfixes
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes JavaScript tests failures in Firefox 49 and Drone.io tests.
The updated drone.io image contains Firefox 49. In this version Mozilla changed their behavior of where to add attributes, which are inserted by JavaScript.
E.g. instead of
<span rel="text" class="highlight">text</span>
The markup now looks like
<span class="highlight" rel="text">text</span>
As we currently run our JavaScript tests on two Firefox versions (39 on Travis, 49 on drone), we need a more generic solution. E.g. the tests are now only looking if the highlight class is added not for the full markup.
Testing Instructions
Review Travis + Drone.io log
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | JavaScript Unit Tests |
@dgt41 hmm not sure. It then would then need to be something like that (yes you can write it shorter):
$('#text-depth-1').children('span').first().hasClass('highlight')
On some even more complex - As we mostly look at generated child elements (or even deeper were we would need find() instead of children()) without direct locators. That's the reason i choose toContain() for now.
What do you think?
Travis is failing here? But maybe it is a different issue?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-07 19:24:22 |
| Closed_By | ⇒ | zero-24 |
Thanks!
how about