User tests: Successful: Unsuccessful:
Pull Request for New Issue (see also #12308).
In a multilingual install with associations, there are several issues with the item language and associations:
You cannot add associations when creating an item. Currently you need to:
You cannot change a content language when editing an item. Currently you need to:
You cannot add associations for unpublished content languages (but you have them across the backoffice)
Clearly, IMHO, this is not a very usable workflow and it comes with issues.
This PR should make that workflow a lot more easy, just add associations, and change the language whenever you need and save (one time).
Also allows to add associations for unpublished content languages.
Note: the only exception is the create/edit modals that will continue to not have Associations tab.
1, Do a code review (hint: use https://github.com/joomla/joomla-cms/pull/12344/files?w=1 to ignore whitespace changes)
2. Use latest 3.7.x, multilingual with associations enabled
3. Apply patch
4. For article, category, contact, menu item and newsfeed items check:
None.
Introduced two new methods: JLanguageHelper::getContentLanguages
(get the content languages from #__languages
) and JLanguageHelper::getInstalledLanguages
(get the installed languages from #__extensions
table).
Why this methods and not using JLanguageHelper::getLanguages()
?
JLanguageHelper::getLanguages()
always return the published languages ... there are several cases we need the unpublisehd ones too ...JLanguageHelper::getLanguages()
is not IMHO totally semantic correct: get what languages? installed languages? content languages?This two methods will allow to do all languages related stuff across the core in the future (replacing several hardcoded queries, etc). I intend to do that step by step is this accepted.
@infograf768 as talked
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Components Language & Strings Layout Libraries JavaScript |
Labels |
Added:
?
?
|
Nope it is not your fault see: #12345 (comment)
now that PR is merged can a mantainer restart travis/drone here?
I restarted drone. No point in restarting travis as it passed
It is a problem with the 3.7.x branch that needs syncing staging into 3.7.x this failed test has nothing to do with this PR.
I tried to restart Drone but it just says pending
This can't be fixed with restarting drone as it is a problem in the 3.7.x branch ;) @brianteeman
ok. so ignore it, because it pass cs and unit tests.
can be tested
will do asap. Your original branch was fine.
I have tested this item
Very clever implementation
One more tester @alikon ?
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
do we have to test again?
don't think so, only fixes conflicts and updated branch
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-28 07:42:57 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
don't really know why drone is failing, something to do with
Highlight
js ... doesn't seem related to this PR