?
avatar andrepereiradasilva
andrepereiradasilva
7 Oct 2016

Steps to reproduce the issue

Update to latest 3.7.x branch
Notice the new clean isis flat design!

Labels and also the message system (Error, Warning, Notice, Message) still have text shadows

image
image

Expected result

No text shadows

Actual result

text shadows

System information (as much as possible)

latest 3.7.x branch

Additional comments

None.

avatar andrepereiradasilva andrepereiradasilva - open - 7 Oct 2016
avatar zero-24 zero-24 - change - 7 Oct 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 7 Oct 2016

@ciar4n @C-Lodder can you take a look here?

avatar C-Lodder
C-Lodder - comment - 7 Oct 2016

sure, just need to clone again

avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Oct 2016

just notice some more shadows
image

avatar brianteeman brianteeman - change - 7 Oct 2016
Category Templates (admin)
avatar C-Lodder
C-Lodder - comment - 7 Oct 2016

Ok I've had a look at the text shadows and Bootstrap 2 also uses them in the same place, apart from the button screenshot that @andrepereiradasilva showed above.

If you want to just remove the text-shadow from the buttons, then simply add the following to the template.less file:

.btn {
    text-shadow: none;
}

If you want to completely remove every text-shadow in all selectors, you can either find all selectors that use them and add:

.selector1, .selector2, .etc {
    text-shadow: none;
}

OR:

* {
    text-shadow: none;
}
avatar ciar4n
ciar4n - comment - 7 Oct 2016

Following is the full list elements with text-shadow applied in the Isis BS 2.3..

.alert,
.close,
.alert-options,
.nav-header,
.input-append .add-on,
.input-prepend .add-on,
.nav-list > li > a,
.nav-list .nav-header,
.nav-list > .active > a,
.nav-list > .active > a:hover,
.nav-list > .active > a:focus,
.navbar .brand,
.navbar .nav > li > a,
.navbar-inverse .brand,
.navbar-inverse .nav > li > a,
.navbar-inverse .navbar-search .search-query:focus,
.navbar-inverse .navbar-search .search-query.focused,
.breadcrumb > li,
.label,
.badge,
.progress .bar,
.nav-tabs.nav-dark,
.subhead {
  text-shadow: none;
}

I think the select all method is probably best as I can't imagine any use for text-shadow in a flat design. At least until we move away from BS 2.3

* {
    text-shadow: none;
}
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Oct 2016

one more little think
image

the modals Save button mouseover

avatar C-Lodder
C-Lodder - comment - 16 Oct 2016

The PR for this was merged so can we close this?

avatar wilsonge wilsonge - change - 16 Oct 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-10-16 14:28:38
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Oct 2016
avatar wilsonge
wilsonge - comment - 16 Oct 2016

Closed. Let's open specific issues for any other work that needs to be done on top of that PR :)

Add a Comment

Login with GitHub to post a comment