Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12346] - [3.7.x] Fix typo in the isis css file

? Failure

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
7 Oct 2016

Pull Request for Issue raised here: #12319 (comment)

Summary of Changes

Fiy typo on fixing conflicts

Testing Instructions

review

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 7 Oct 2016
avatar zero-24 zero-24 - change - 7 Oct 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2016
Category ⇒ Administration Templates (admin)
avatar zero-24
zero-24 - comment - 7 Oct 2016

hmm i did get a different diff please double check that @C-Lodder @ciar4n

avatar C-Lodder
C-Lodder - comment - 7 Oct 2016

This need to be done in the LESS file.

@zero-24 - It was a 1px difference for the blue background.

avatar ciar4n
ciar4n - comment - 7 Oct 2016

@C-Lodder The LESS file appears to be correct (-26px). When compiled it changes the CSS from -25px to -26px. Although we should also be seeing a similar change in the template-rtl.css

@zero-24 Have the changes here been the result of the LESS been compiled or have you edited the CSS directly?

avatar zero-24
zero-24 - comment - 7 Oct 2016

Should be correct now? All three places have now -26px

avatar ciar4n
ciar4n - comment - 7 Oct 2016

Here is the CSS compiled from the LESS files.. ciar4n@350807b

avatar zero-24
zero-24 - comment - 7 Oct 2016

done thanks @ciar4n and @C-Lodder

avatar zero-24
zero-24 - comment - 8 Oct 2016

fixed with: #12349

avatar zero-24 zero-24 - change - 8 Oct 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-10-08 13:17:17
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 8 Oct 2016

Add a Comment

Login with GitHub to post a comment