[#11971] - Fix button classes
- Fixed in Code Base
- 7 Sep 2016
- Medium
- Build: 3.7.x
- # 11971
- Diff
- C-Lodder:buttons
- Failure continuous-integration/drone the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11949
Summary of Changes
This PR fixes the class (success or danger) added to buttons.
Testing Instructions
In the backend, open an article in the Article Manager. You'll notice any button labelled "Yes" will have a red background and any button labelled "No" will have a green button.
Apply the patch and this will reverse the colours to their correct state
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Templates (admin) Administration |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11971.
| Status | Pending | ⇒ | Ready to Commit |
RTC
Should we remove the release blocker label?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-07 15:19:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
We remove it when the PR gets merged :)
when it is merged
On 7 September 2016 at 15:52, Lodder notifications@github.com wrote:
Should we remove the release blocker label?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11971 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZLbfvlxXZibkgFjA-zwkMq4WmDLks5qns_EgaJpZM4J27GF
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item✅ successfully on
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11971.