[#11972] - Improve menu item duplicate alias error message
- Closed
- 8 Sep 2016
- Medium
- Build: staging
- # 11972
- Diff
- andrepereiradasilva:patch-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: 3 brianteeman, sonalitailored, truptikagathara Unsuccessful: 0
Summary of Changes
Improve menu item duplicate alias error message so we don't need to guess which menu item is the one that have duplicate alias.
Before
After
Testing Instructions
- Code review
- Apply patch
- Try to save two menu items with the same alias so you can view the new error message.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Administration Libraries |
| Labels |
Added:
?
?
|
||
| Labels |
Removed:
?
?
|
||
| Labels |
Added:
?
?
|
||
I like the addition to say which menu item clashes
I dont like the rest of the novel that you wrote
the "novel" is an explanation why the error occurs so people can understand, if more people don't like i can remove that part.
You tried to call x the same as x
That's enough. Now you are naming it there is even less reason to write a
novel
ok @brianteeman you convinced me, removed the "novel".
Thanks and sorry but now I realise it does need the trashed comment still.
I made a suggestion inline
On 7 September 2016 at 19:31, andrepereiradasilva notifications@github.com
wrote:
ok @brianteeman https://github.com/brianteeman you convinced me,
removed the "novel".—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11972 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Yz6e7qSqzSExOyC3pRLJa9rqDeoks5qnwMRgaJpZM4J3B9i
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11972.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11972.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11972.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-08 06:11:01 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I suggest to modify this PR by modifying the string
+JLIB_DATABASE_ERROR_MENU_UNIQUE_ALIAS="The alias <strong>%s</strong> is already being used by <strong>%s</strong> menu item in the <strong>%s</strong> menu (remember it may be a trashed item)."
to
+JLIB_DATABASE_ERROR_MENU_UNIQUE_ALIAS="The alias <strong>%1$s</strong> is already being used by <strong>%2$s</strong> menu item in the <strong>%3$s</strong> menu (remember it may be a trashed item)."
as we have 3 variables that could be confused by TTs in some languages.
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on
Based on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11972.