PR-staging

Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
7 Sep 2016

Pull Request for Issue #11967.

Steps to reproduce the issue

Create a site using the beez template
Create an article and add it to a menu item and use the protostar template for that menu item
In the front end login and edit the article
Select the insert image from the wysiwyg toolbar to open the image select modal

Expected result

The modal opens in an iframe and is using the assigned protostar template

Actual result

The modal opens in an iframe and is using the default template for the site - in this case beez

Testing

Repeat the above step once you have applied this patch with patchtester

avatar dgt41 dgt41 - open - 7 Sep 2016
avatar brianteeman brianteeman - test_item - 7 Sep 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Sep 2016

I have tested this item successfully on 01eace4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11970.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2016
Category Media Manager Administration Components Plugins Front End
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Sep 2016

found one thing that i don't know if is an issue, but did not existed before the patch ... if you set &template= now you get
image
Try with /index.php?option=com_media&view=images&template= and you will see.

For the rest seems to works fine

avatar dgt41
dgt41 - comment - 13 Sep 2016

@andrepereiradasilva last commit should fix that

avatar tomartailored tomartailored - test_item - 19 Sep 2016 - Tested successfully
avatar tomartailored
tomartailored - comment - 19 Sep 2016

I have tested this item successfully on d0320ae

I have tested this item successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11970.

avatar tomartailored
tomartailored - comment - 19 Sep 2016

screen shot 2016-09-19 at 01 03 38Please check the attachment
screen shot 2016-09-19 at 01 03 41


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11970.

avatar dgt41 dgt41 - close - 11 Oct 2016
avatar dgt41 dgt41 - close - 11 Oct 2016
avatar dgt41 dgt41 - head_ref_deleted - 11 Oct 2016
avatar dgt41 dgt41 - change - 11 Oct 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-10-11 11:34:07
Closed_By dgt41
avatar brianteeman
brianteeman - comment - 11 Oct 2016

Why did this get closed?

avatar dgt41 dgt41 - head_ref_restored - 11 Oct 2016
avatar dgt41
dgt41 - comment - 11 Oct 2016

@brianteeman I was trying to delete some outdated branches and this one was closed by mistake, you can re open it (although I am not convinced by my own solution here)

avatar dgt41 dgt41 - change - 11 Oct 2016
Status Closed New
Closed_Date 2016-10-11 11:34:07
Closed_By dgt41
avatar dgt41 dgt41 - reopen - 11 Oct 2016
avatar dgt41 dgt41 - reopen - 11 Oct 2016
avatar brianteeman
brianteeman - comment - 11 Oct 2016

I wouldnt know about the validity of the fix and i havent had the time to check it properly yet BUT it is a real issue

avatar brianteeman
brianteeman - comment - 16 Oct 2016

Retested and it had no effect - and of course (i now realise) only addresses the issue with the editors-xtd button loading the media manager - the same issue exists for the media manager link from the images and link tab image selects


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11970.

avatar dgt41 dgt41 - close - 20 Oct 2016
avatar dgt41
dgt41 - comment - 20 Oct 2016

@brianteeman I am gonna close this. The part I am fixing here it's not the root of the problem

avatar dgt41 dgt41 - change - 20 Oct 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-10-20 18:54:19
Closed_By dgt41
avatar dgt41 dgt41 - close - 20 Oct 2016
avatar dgt41 dgt41 - head_ref_deleted - 20 Oct 2016
avatar brianteeman
brianteeman - comment - 25 Oct 2016

it absolutely needs fixing though even if this isnt the correct fix

On 20 October 2016 at 18:54, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman I am gonna close this. The
part I am fixing here it's not the root of the problem


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11970 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8SfyQtEDeUH-KDlGD95DDRTbHTHsks5q17jbgaJpZM4J27Ai
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Add a Comment

Login with GitHub to post a comment