Can you please provide steps to test this PR?

Beside the test instructions. Please explain what kind of functionality it adds that you can't do as is.
Did you base your code on #11157? I think a lot of code is already in that PR.

Personally I like any functionality/usability added to the editor. ?

Now that you have created a real plugin for jdragdrop wouldn't it be better if the associated javascript was moved with it

@brianteeman but it is:

    <media folder="jdragdrop" destination="editors/tinymce/plugins/jdragdrop">
         <file>plugin.js</file>
         <file>plugin.min.js</file>
     </media>

I meant outside of tinymce own root. It will make maintenance of tinymce
much easier. But maybe that's just me?

On 29 Aug 2016 9:04 p.m., "Dimitri Grammatikogianni" <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman but it is:

<media folder="jdragdrop" destination="editors/tinymce/plugins/jdragdrop">
     <file>plugin.js</file>
     <file>plugin.min.js</file>
 </media>

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#11829 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fNZXtu5AMCprD4sYcHtdqXP19yYks5qkzsigaJpZM4JvA91
.

@schnuti @RonakParmar - now there are testing instructions

@brianteeman there was a decision that tinymce plugins will be stored in the location editors/tinymce/plugins as it makes the integration way to easier to implement. The maintenance is a chapter which needs to be rewritten in j4 with npm/gulp (or similar tools)

Just seems wrong to me.

I agree with @brianteeman
1. Why not use the in TinyMCE built in functionality to load scripts from "external sources"? I tested it as in #11157. 'path/to/plugin.js' can point to e.g.
JUri::root().'media/cms/js/tinymce/cmsbutton.min.js'
or
JUri::root().'media/com_mycomp/js/tinymce/mybutton.min.js'
or
real external path like a CDN.
You could define rules to allow overrides.
2. How to activate other (new) standard TinyMCE plugins and buttons without coding?

Another thing is the buttons. Wouldn't it be better to merge all (6) cms buttons into one plugin.js?
This only means that the buttons have to be defined in another way then by loaded xtd-plugin. "button-Article" instead of "buttonX-Article". May not be possible in 3.x?

Edit: The js code would then not be loaded into the HTML-header.

Sorry for not keeping this in one post.

The new plugin type should return a second parameter with the button(s). In that way one plugin can define more than one button or no buttons at all. Plugin code is not necessary = one button.
If you need more dynamic buttons the code has to be splitted.
Why not also allow to return also without plugin but only buttons or more then one plugin?

array(array('the plugins'), array('the buttons')

Is this still being worked on?

I hope not. The tinyMCE "workflow" has changed a lot since aug. 2016. Any proposal would do better in a new issue.

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/11829

closed as comments above. Feel free to reopen if needed.

@franz-wohlkoenig can you please reopen this one?

Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/11829

done

@dgrammatiko one year ago you asked for this abandoned pr to be re-opened as there has been no further activity I am closing it again as abandoned. If you wanted it to be kept open as a todo-list reminder for you then I guess it didn't work - and this isnt the place