The Travis errors are just long lines. I will fix them later.

I have tested this item ✅ successfully on 26370b8

Really happy to see this!!!

On 29 August 2016 at 05:47, Killol Tailored notifications@github.com
wrote:

I have tested this item ✅ successfully on 26370b8

26370b8

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11830
https://issues.joomla.org/tracker/joomla-cms/11830.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11830 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8SkytNZFVyoFO2EdmTYzWr1wMXBpks5qkmRlgaJpZM4JvDcT
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I have tested this item ✅ successfully on 26370b8

Travis not happy
FILE: ...ms/administrator/components/com_content/models/fields/modal/article.php

FOUND 0 ERROR(S) AND 6 WARNING(S) AFFECTING 6 LINE(S)

212 | WARNING | Line exceeds 150 characters; contains 172 characters

214 | WARNING | Line exceeds 150 characters; contains 156 characters

216 | WARNING | Line exceeds 150 characters; contains 159 characters

238 | WARNING | Line exceeds 150 characters; contains 173 characters

240 | WARNING | Line exceeds 150 characters; contains 157 characters

242 | WARNING | Line exceeds 150 characters; contains 160 characters

its an RFC travis doesnt need to be happy ;)

On 29 August 2016 at 10:48, infograf768 notifications@github.com wrote:

Travis not happy
FILE: ...ms/administrator/components/com_content/models/

fields/modal/article.php

FOUND 0 ERROR(S) AND 6 WARNING(S) AFFECTING 6 LINE(S)

212 | WARNING | Line exceeds 150 characters; contains 172 characters

214 | WARNING | Line exceeds 150 characters; contains 156 characters

216 | WARNING | Line exceeds 150 characters; contains 159 characters

238 | WARNING | Line exceeds 150 characters; contains 173 characters

240 | WARNING | Line exceeds 150 characters; contains 157 characters

242 | WARNING | Line exceeds 150 characters; contains 160 characters

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11830 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8QZO7kbmMy0SvalJ8Bc4Iw26HWlwks5qkqsKgaJpZM4JvDcT
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@dgt41 @JoomliC can you guys test this and also from a B/C perspective.

@brianteeman changed.

BTW, besides this ones:

• menu item single article (select, edit, create, clear)
• user profile plugin tos (select, edit, create, clear)
• tinymce select article (select)
• article associations (select, edit, create, clear - with forcedLanguage)

Anyone know if the article modal is used anywhere else?

I have tested this item ✅ successfully on 3c2e211

@veronikapatel @truptikagathara @killoltailored please test again because there where some issues in the multilangual associations article modals.

@andrepereiradasilva

There were reasons why we did not let edit language and category in the modal Edit task in Multilang when JLanguageAssociations::isEnabled().

Therefore, when JLanguageAssociations is NOT enabled there should be no restrictions in the modal Edit Task, i.e. it should behave the same as your new Create task in both Monolingual and Multilingual sites.

Now, when JLanguageAssociations::isEnabled() for the Edit task:

A- Case when using the article_modal in the ASSOCIATIONS tab
Category was readonly because we did not know to which language the category was set and therefore we could create an issue if it was changed to a category set to another content language. You do solve this gracefully by presenting in the category field only those set to the language concerned or All, while keeping the language read-only for the article itself. Great!

B- Case when using the article_modal everywhere else
That is a totally different matter and there is still a reason to force the Content Language to be read-only.
For example when using the modal to edit an article selected for a Single Article menu item, we do NOT know if the article itself is associated or not.
Therefore we take the risk of totally breaking the existing article associations by changing the Content Language without a single hint that we are doing that.

This also the case for all use of a modal for Edit Task (contacts, categories, newsfeeds, menu items -in 3.7-).
I suggest you modify your PR. If possible it would check for JLanguageAssociations::isEnabled() and if the article IS associated and display as readonly the language field in that case.

Note: I also found a bug unrelated to this PR
3 articles (or more) are associated: en-GB, it-IT pt-PT
Edit one of them and change its Content Language to All.
Expected Result: that article is no more associated to the 2 others BUT the 2 others remain associated between themselves.
Result: All associations are deleted.
Will create an issue.

@infograf768 ok
so

A- Case when using the article_modal in the ASSOCIATIONS tab

all fine them

B- Case when using the article_modal everywhere else

fixed with f38d89d

// If not in associations modal, block the language change if in edit modal, language not All and associations enabled.

Note: I also found a bug unrelated to this PR

Please make a PR for that them. not related to this.

Please test again and confirm all is fine now.

already done @zero-24

@test

Looks like mostly working.
One remaining issue in multilingual : we can't create a new article in Category set to All, i.e. the category does not display in the dropdown

Forget that issue, the dropdown for categories was not fully displaying until the modal was scrolled down...

Made a change now you can Save & Close directly on create. Previously you needed to press Save, wait for be processed and them click "Save & Close" or "Close".

one less step ;)

solved some leftover issues. hope all fine now.

@dgt41 @JoomliC since you worked with this modals before i would really aprecciate your feedback on this.

I have tested this item ✅ successfully on

I have tested this item successfully

I have tested this item ✅ successfully on 325950e

OK here, but this needs more than 2 testers imho.

As it will be a new feature we can flag it for extra testing during the
beta stage

On 31 August 2016 at 11:17, infograf768 notifications@github.com wrote:

I have tested this item ✅ successfully on 325950e
325950e

OK here, but this needs more than 2 testers imho.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11830
https://issues.joomla.org/tracker/joomla-cms/11830.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11830 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8funi6b-_9sh6yiAart4cx2xQY3tks5qlVTWgaJpZM4JvDcT
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

so 3.7.0 right?

if so i will make similar PR for newsfeeds, contacts, categories (and menus in 3.7.x branch)

Yes.

Ok all four PR are done:

• Article: #11830 (this one)
• Category: #11857
• Contact: #11858
• Newsfeed: #11862

I guess you need to do one or weblinks as well

I guess you need to do one or weblinks as well

weblinks does not have single weblink menu item, nor associations, nor modal field

BTW, side comment: with the amount of New Feature labels in PR (https://github.com/joomla/joomla-cms/pulls?q=is%3Apr+label%3A%22New+Feature%22+milestone:%22Joomla+3.7.0%22) i guess 3.7.x will be full of new features 👍 (and 3.6 was only released two months ago ...)

I guess you don't need to then :)

I have found just a smal glitch.

on every page we have rounded ends of the buttons. but not here. This applys to all PRs so i just want to raise it here. Everything else looks great.

And maybe a bigger problem (at least for multilangual sites) ;)

On the new modal the Association tab is missing, i'm not sure if that is expected or not as you told us to test it?:

@zero-24 fixed with #11832

On the new modal the Association tab is missing, i'm not sure if that is expected or not as you told us to test it?:

That is expected. @infograf768 care to explain why?

As long as it expected i'm ok with that.

That is expected. @infograf768 care to explain why?

For create new article: 2 situations in multilang when associations are implemented.

A- Case when using the article_modal in the ASSOCIATIONS tab
We should not set any associations in the modal as we are creating a new one for an article in a specific language.

B- Case when using the article_modal everywhere else
We do not know if the articles with which we would associate the new article are not already associated with other articles, therefore we could break existing associations.

Thanks. 👍

Removed RFC from the title ;)

so tested with success @zero-24 ?

I have tested this item ✅ successfully on 325950e

Looks good to me.

RTC. To be marked as extra testing in the beta phase.

maybe create a "beta extra testing" label ;)

i did not have access to the label thing maybe @brianteeman can help?

No I dont think we need an extra label. We will just need to make sure to
stress all the new features in the alpha/beta/rc announcements

On 1 September 2016 at 14:00, zero-24 notifications@github.com wrote:

i did not have access to the label thing maybe @brianteeman
https://github.com/brianteeman can help?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11830 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bZpzbCbY_s5EunVEdyTpZ5UyEn_ks5qlsxWgaJpZM4JvDcT
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Merged with 7d97f7f