Feeling Lucky
?
[#11828] - Remove deprecated modal instance
- Fixed in Code Base
- 29 Aug 2016
- Medium
- Build: staging
- # 11828
- Diff
- wilsonge:deprecatedmodal
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JHtml::_('bootstrap.modal') has been deprecated for some time in favour of the other modal function JHtml::_('bootstrap.renderModal') as it was buggy (e.g. #6918)
This PR removes this last instance of it's use in core
Testing Instructions
Check the batch modal can still be opened and used.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
dgt41
- comment
- 28 Aug 2016
@brianteeman the actual code is not removed, the calling is renamed to the new function.
dgt41
- comment
- 28 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11828.
bhavikTailored
- comment
- 29 Aug 2016
Hello brianteeman,
- I have checked all files in joomla and there we have used "bootstrap.renderModal" without only following file, "administrator/components/com_modules/views/modules/view.html.php".
- after patch it's working so we should RTC.
- So we would like for code consistency.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11828.
bhavikTailored
- comment
- 29 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11828.
BhaveshTailored
- comment
- 29 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11828.
RonakParmar
- comment
- 29 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11828.
| Status | Pending | ⇒ | Ready to Commit |
wilsonge
- comment
- 29 Aug 2016
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-29 17:31:46 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
There is some confusion? in PLT on when depreated code can be removed
On 28 August 2016 at 20:42, George Wilson notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/