? Success

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
25 Aug 2016

Pull Request for Issue #11790

Summary of Changes

This PR adds a small polyfill for indexOf() which is not supported in IE8. Without this, the Search Tools will not work due to Javascript errors.

Testing Instructions

  • Open IE8 (or open IE11 and set it to IE8 emulation)
  • Go to Module Manager
  • Click on the Search Tools button

Documentation Changes Required

None

avatar C-Lodder C-Lodder - open - 25 Aug 2016
avatar C-Lodder C-Lodder - change - 25 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Category JavaScript
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 25 Aug 2016

@zero-24 yes, so anyone who looks there knows what it does. It's only for the uncompressed version

avatar killoltailored killoltailored - test_item - 26 Aug 2016 - Tested successfully
avatar killoltailored
killoltailored - comment - 26 Aug 2016

I have tested this item successfully on 201cc1d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11794.

avatar killoltailored
killoltailored - comment - 26 Aug 2016

Tested successfully with Joomla Version : Joomla! 3.6.3-dev Development [ Noether ] 5-August-2016 00:32 GMT
And System Windows 8.1, screen shot 2016-08-26 at 03 44 50IE8 emulation


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11794.

avatar RonakParmar RonakParmar - test_item - 27 Aug 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 27 Aug 2016

I have tested this item successfully on 201cc1d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11794.

avatar brianteeman brianteeman - change - 27 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 27 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11794.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 27 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-27 18:13:21
Closed_By rdeutz
avatar rdeutz rdeutz - close - 27 Aug 2016
avatar rdeutz rdeutz - merge - 27 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment