Feeling Lucky
?
[#11793] - [Sql azure] Normalize joomla install sample brochure sql file
- Fixed in Code Base
- 27 Aug 2016
- Medium
- Build: staging
- # 11793
- Diff
- andrepereiradasilva:patch-23
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Normalizes all sql azure joomla sample_brochure.sql install file.
- always use
SET IDENTITY_INSERT [#__xxxx] ON/OFF; -
INSERTtoINSERT INTO - Quote all table names and db field names
- Always use
'to quote string values. - solves several problems in the file
- Code style
Testing Instructions
Mainly code review. (to many changes need to check code in raw)
https://github.com/andrepereiradasilva/joomla-cms/blob/patch-23/installation/sql/sqlazure/sample_brochure.sql
If anyone could test an install of sample brochure 3.6.x would be great. Don't have sql azure to test,
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation SQL MS SQL |
| Labels |
Added:
?
|
||
waader
- comment
- 26 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11793.
alikon
- comment
- 26 Aug 2016
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11793.
andrepereiradasilva
- comment
- 27 Aug 2016
can we get a RTC here?
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 27 Aug 2016
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-27 18:13:35 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
solved