User tests: Successful: Unsuccessful:
Normalizes all sql azure joomla sample_data.sql install file.
SET IDENTITY_INSERT [#__xxxx] ON/OFF;
INSERT
to INSERT INTO
'
to quote string values.Mainly code review. (to many changes need to check code in raw)
https://github.com/andrepereiradasilva/joomla-cms/blob/patch-24/installation/sql/sqlazure/sample_data.sql
If anyone could test an install of sample data 3.6.x would be great. Don't have sql azure to test,
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Installation SQL MS SQL |
Labels |
Added:
?
|
I have tested this item
I get this message:
[Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'SELECT'. SQL=INSERT INTO #__menu VALUES (1, '', 'Menu_Item_Root', 'root', '', '', '', '', 1, 0, 0, 0, 0, '1900-01-01 00:00:00', 0, 0, '', 0, '', 0, 229, 0, '', 0 SELECT 2, 'menu', 'com_banners', 'Banners', '', 'Banners', 'index.php?option=com_banners', 'component', 0, 1, 1, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners', 0, '', 3, 12, 0, '', 1 UNION ALL SELECT 3, 'menu', 'com_banners', 'Banners', '', 'Banners/Banners', 'index.php?option=com_banners', 'component', 0, 2, 2, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners', 0, '', 4, 5, 0, '', 1 UNION ALL SELECT 4, 'menu', 'com_banners_categories', 'Categories', '', 'Banners/Categories', 'index.php?option=com_categories&extension=com_banners', 'component', 0, 2, 2, 6, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners-cat', 0, '', 6, 7, 0, '', 1 UNION ALL SELECT 5, 'menu', 'com_banners_clients', 'Clients', '', 'Banners/Clients', 'index.php?option=com_banners&view=clients', 'component', 0, 2, 2, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners-clients', 0, '', 8, 9, 0, '', 1 UNION ALL SELECT 6, 'menu', 'com_banners_tracks', 'Tracks', '', 'Banners/Tracks', 'index.php?option=com_banners&view=tracks', 'component', 0, 2, 2, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners-tracks', 0, '', 10, 11, 0, '', 1 UNION ALL SELECT 7, 'menu', 'com_contact', 'Contacts', '', 'Contacts', 'index.php?option=com_contact', 'component', 0, 1, 1, 8, 0, '1900-01-01 00:00:00', 0, 0, 'class:contact', 0, '', 13, 18, 0, '', 1 UNION ALL SELECT 8, 'menu', 'com_contact', 'Contacts', '', 'Contacts/Contacts', 'index.php?option=com_contact', 'component', 0, 7, 2, 8, 0, '1900-01-01 00:00:00', 0, 0, 'class:contact', 0, '', 14, 15, 0, '', 1 UNION ALL SELECT 9, 'menu', 'com_contact_categories', 'Categories', '', 'Contacts/Categories', 'index.php?option=com_categories&extension=com_contact', 'component', 0, 7, 2, 6, 0, '1900-01-01 00:00:00', 0, 0, 'class:contact-cat', 0, '', 16, 17, 0, '*', 1
... and so on
@bhavikTailored to test this you can't use the patchtester as this is a installation only fix. You need to download the branch and install it on a mssql database
@bhavikTailored just install this https://github.com/andrepereiradasilva/joomla-cms/archive/patch-24.zip in mssql with sample data selected.
I have tested this item
Works now, thanks!
thaks @waader
one more for RTC @brianteeman
I have tested this item
on code review (hoping that now is better than my previous one) ;)
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-30 12:38:29 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
I have tested this item✅ successfully on d028c30
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.