? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
25 Aug 2016

Summary of Changes

Normalizes all sql azure joomla sample_data.sql install file.

  • always use SET IDENTITY_INSERT [#__xxxx] ON/OFF;
  • INSERT to INSERT INTO
  • Quote all table names and db field names
  • Always use ' to quote string values.
  • Code style

Testing Instructions

Mainly code review. (to many changes need to check code in raw)
https://github.com/andrepereiradasilva/joomla-cms/blob/patch-24/installation/sql/sqlazure/sample_data.sql

If anyone could test an install of sample data 3.6.x would be great. Don't have sql azure to test,

Documentation Changes Required

None.

@waader @alikon please test.

avatar andrepereiradasilva andrepereiradasilva - open - 25 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 25 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Category Installation SQL MS SQL
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Added: ?
avatar alikon alikon - test_item - 26 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 26 Aug 2016

I have tested this item successfully on d028c30

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.

avatar waader waader - test_item - 26 Aug 2016 - Tested unsuccessfully
avatar waader
waader - comment - 26 Aug 2016

I have tested this item ? unsuccessfully on d028c30

I get this message:
[Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'SELECT'. SQL=INSERT INTO #__menu VALUES (1, '', 'Menu_Item_Root', 'root', '', '', '', '', 1, 0, 0, 0, 0, '1900-01-01 00:00:00', 0, 0, '', 0, '', 0, 229, 0, '', 0 SELECT 2, 'menu', 'com_banners', 'Banners', '', 'Banners', 'index.php?option=com_banners', 'component', 0, 1, 1, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners', 0, '', 3, 12, 0, '', 1 UNION ALL SELECT 3, 'menu', 'com_banners', 'Banners', '', 'Banners/Banners', 'index.php?option=com_banners', 'component', 0, 2, 2, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners', 0, '', 4, 5, 0, '', 1 UNION ALL SELECT 4, 'menu', 'com_banners_categories', 'Categories', '', 'Banners/Categories', 'index.php?option=com_categories&extension=com_banners', 'component', 0, 2, 2, 6, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners-cat', 0, '', 6, 7, 0, '', 1 UNION ALL SELECT 5, 'menu', 'com_banners_clients', 'Clients', '', 'Banners/Clients', 'index.php?option=com_banners&view=clients', 'component', 0, 2, 2, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners-clients', 0, '', 8, 9, 0, '', 1 UNION ALL SELECT 6, 'menu', 'com_banners_tracks', 'Tracks', '', 'Banners/Tracks', 'index.php?option=com_banners&view=tracks', 'component', 0, 2, 2, 4, 0, '1900-01-01 00:00:00', 0, 0, 'class:banners-tracks', 0, '', 10, 11, 0, '', 1 UNION ALL SELECT 7, 'menu', 'com_contact', 'Contacts', '', 'Contacts', 'index.php?option=com_contact', 'component', 0, 1, 1, 8, 0, '1900-01-01 00:00:00', 0, 0, 'class:contact', 0, '', 13, 18, 0, '', 1 UNION ALL SELECT 8, 'menu', 'com_contact', 'Contacts', '', 'Contacts/Contacts', 'index.php?option=com_contact', 'component', 0, 7, 2, 8, 0, '1900-01-01 00:00:00', 0, 0, 'class:contact', 0, '', 14, 15, 0, '', 1 UNION ALL SELECT 9, 'menu', 'com_contact_categories', 'Categories', '', 'Contacts/Categories', 'index.php?option=com_categories&extension=com_contact', 'component', 0, 7, 2, 6, 0, '1900-01-01 00:00:00', 0, 0, 'class:contact-cat', 0, '', 16, 17, 0, '*', 1
... and so on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Aug 2016

@waader thanks
should be fixed now: 6dbe482

avatar bhavikTailored
bhavikTailored - comment - 27 Aug 2016
  • I have tried to patch but there was error display like "PatchTester\Model\PullModel::revert - Error retrieving table data ([])".
  • Can you give me information what is problem there?
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.
avatar zero-24
zero-24 - comment - 27 Aug 2016

@bhavikTailored to test this you can't use the patchtester as this is a installation only fix. You need to download the branch and install it on a mssql database

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Aug 2016

@bhavikTailored just install this https://github.com/andrepereiradasilva/joomla-cms/archive/patch-24.zip in mssql with sample data selected.

avatar waader waader - test_item - 27 Aug 2016 - Tested successfully
avatar waader
waader - comment - 27 Aug 2016

I have tested this item successfully on 6dbe482

Works now, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Aug 2016

thaks @waader
one more for RTC @brianteeman

avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Aug 2016

@alikon can you please test this one again so we get a RTC here? (is the last one)

avatar alikon alikon - test_item - 29 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 29 Aug 2016

I have tested this item successfully on 6dbe482

on code review (hoping that now is better than my previous one) ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.

avatar zero-24 zero-24 - change - 29 Aug 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 29 Aug 2016

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11795.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 30 Aug 2016
avatar rdeutz rdeutz - merge - 30 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 30 Aug 2016
avatar rdeutz rdeutz - change - 30 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-30 12:38:29
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment