[#10687] - [com_redirect] Solve javascript error on bulk import modal close
- Closed
- 1 Jun 2016
- Medium
- Build: staging
- # 10687
- Diff
- andrepereiradasilva:patch-17
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
There is a javascript error on closing the "Bulk Import" modal of com_redirect.
This simple PR fixes it.
Testing Instructions
Code review, or:
1. Use latest staging
2. Open dev console on chrome
3. Go to Components -> Redirects and press "Bulk Import", the modal opens
4. Press "Cancel" on the modal, you'll see a javascript error on chrome console
5. Apply patch.
6. Repeat test, no js error.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
it was already like that, but ok i changed.
Yes, i know ;-)
But maybe good to start using code standards for all modified lines
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10687.
| Category | ⇒ | JavaScript |
I have tested this item
Firebug for FF detects this error too.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10687.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-01 19:10:53 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
it was already like that, but ok i changed.