[#10688] - [com_redirect] Improve disabled redirect plugin message
- Fixed in Code Base
- 1 Jun 2016
- Medium
- Build: staging
- # 10688
- Diff
- andrepereiradasilva:better-redirecct-message
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Simple PR to improve the disable redirect system plugin message in com_redirect.
Before (message is an error and the link is to the plugin list with harcoded text search)
After (message is a warning and the link is now to edit the redirect system plugin)
Testing Instructions
Code review, or:
1. Use latest staging
2. Disable redirect systme plugin
3. Go to Components -> Redirect and check the error message. Click the link, you'll be redirected to the plugin manager list view with a search.
4. Apply patch
5. Go to Components -> Redirect and check the warning message. Click the link, you'll be redirected to directly edit the redirect plugin.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
what is the benefit of the code change to stop it being a hard link in the language file?
IMO you shouldn't depend on the translate for the links to be correct.
We have ids for the extensions, so we should use it.
And presumably if accepted you will be doing the same for other hard coded links in language strings.
right
| Category | ⇒ | Language & Strings Templates (admin) |
| Labels | |||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10688.
I have tested this item
Indeed, we should manage to use non hardcoded links when possible in language strings.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10688.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10688.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-01 19:15:03 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
| Labels |
Removed:
?
|
||
Other than the obvious change from an error to a warning what is the benefit of the code change to stop it being a hard link in the language file? And presumably if accepted you will be doing the same for other hard coded links in language strings.