Feeling Lucky
?
[#10517] - [js message system] Add close button
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 10517
- Diff
- andrepereiradasilva:js-close
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
This simple PR adds a close button to the JS message system, just like the one that exists for the php message system.
This applies to all js messages (error, warning, success or info messages).
Testing Instructions
- Use latest staging
- Go to Menus -> Message -> Add new menu item and Save without any field, you'get a js erro message.
- Apply patch, refresh browser cache and repeat the same process, you'll now get a close button in the message (test it)
Test also on frontend js messages (ex: email remainder or other).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- comment
- 16 May 2016
I have tested this item 
successfully on 015a289
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517.
| Category | ⇒ | Administration JavaScript |
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 16 May 2016
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 22:17:18 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 16 May 2016
Thanks everybody
| Milestone |
Added: |
||
I have tested this item
successfully on 015a289
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10517.