? Pending

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
16 May 2016

Improve modals to select and to edit a news feed.
Note: to be testing on staging.

Summary of Changes

  • When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
  • Remove inline CSS
  • Content is embedded in a container div (using already existing container-popup class for modal.php)
  • Add empty lines to improve the readability
  • Add viewport dimensions (new 3.6.0-dev)
  • News feed edit modal is simplified (load edit layout, so no dupplicated code)
  • Fix Edit button when current associated news feed in data is not the selected news feed
  • Control if modal, in edit layout
  • Add Save (keep modal open), Save & Close and Close button to the footer of the modal
  • Fix Edit modal not opening as a modal (missing bootstrap.renderModal for Edit modal)
  • Fix consistency of fieldsets $this->ignore_fieldsets, and add missing tabs, and remove dupplicated fieldset metadata (as using now correct edit view inside the modal)

Testing Instructions (Staging + Multilanguages enabled!)

  • Go to Components > News Feeds > open a news feed, and go to Associations tab to select associated news feed to open the modal.
  • Verify tooltip placement is bottom, and not truncated
  • Verify the modal size now is proportionnal to viewport (modal is 80/100th viewport width, and modal-body is 70/100th viewport height)
  • Select an associated news feed and save the news feed to show edit button
  • Open Edit modal and play with it ;-)
  • Do the same in a menu item type "Single news feed", for Select and Edit news feed.

Same rendering as for Categories in PR #10441 (screenshots)

avatar JoomliC JoomliC - open - 16 May 2016
avatar JoomliC JoomliC - change - 16 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 16 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

I have tested this item :white_check_mark: successfully on 2e2f7e1

All worked fine.
Great work again!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516.

avatar BurtNL BurtNL - test_item - 16 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 16 May 2016

I have tested this item :white_check_mark: successfully on 2e2f7e1

Tested successfully, works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516.

avatar brianteeman brianteeman - change - 16 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 16 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516.

avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 16 May 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 16 May 2016
Category Components
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 16 May 2016
Milestone Added:
avatar roland-d roland-d - change - 16 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-16 22:15:12
Closed_By roland-d
avatar roland-d roland-d - close - 16 May 2016
avatar roland-d roland-d - merge - 16 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 May 2016
avatar roland-d
roland-d - comment - 16 May 2016

Thanks everybody

avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment