Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10515] - [com_categories] Coding standards xml + fix a wrong closing tag

? Success

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
16 May 2016

Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tag, form xml files com_contact

Summary of Changes

categories.xml

  • Remove extra empty lines at end of xml file

models/forms/category.xml

  • Code standards
  • Add emtpy line before each opening tag (readability)
  • Fix wrong field closing tag : tags

models/forms/filter_categories.xml

  • Code standards
  • Add emtpy line before each opening tag (readability)

Testing Instructions

  • code review
  • apply and test all is working as before
avatar JoomliC JoomliC - open - 16 May 2016
avatar JoomliC JoomliC - change - 16 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Added: ?
avatar JoomliC JoomliC - change - 16 May 2016
Title
…
Coding standards com categories xml
[com_categories] Coding standards xml + fix a wrong closing tag
avatar JoomliC JoomliC - change - 16 May 2016
Title
…
Coding standards com categories xml
[com_categories] Coding standards xml + fix a wrong closing tag
avatar andrepereiradasilva andrepereiradasilva - test_item - 16 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

I have tested this item :white_check_mark: successfully on c63a85a

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515.

avatar JoomliC
JoomliC - comment - 16 May 2016

@andrepereiradasilva Thanks for testing! (maybe we could work on some extra code standards rules/recommendations? ;-) )

avatar BurtNL BurtNL - test_item - 16 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 16 May 2016

I have tested this item :white_check_mark: successfully on c63a85a

I have tested Categories without the patch and with the patch applied.
I could not find differences, so successfully tested.

However, I have spotted an issue related to the changes to modals recently done and which are already merged into the latest staging.
@JoomliC: I will report the issue.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515.

avatar brianteeman brianteeman - change - 16 May 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 16 May 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10515.

avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 16 May 2016
Milestone Added:
avatar roland-d roland-d - change - 16 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-16 22:09:56
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 16 May 2016
avatar roland-d roland-d - merge - 16 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 May 2016
avatar roland-d roland-d - reference | 2125659 - 16 May 16
avatar roland-d roland-d - merge - 16 May 2016
avatar roland-d roland-d - close - 16 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 16 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment