Joomla! Issue Tracker - Patch Tester

Download
Launch
Feeling Lucky

[#264] - Link to Patch Tester after installation

Success

User tests: Successful: Unsuccessful:

avatar mtmeyrick
mtmeyrick
4 Apr 2020

Link to Patchtester after Installation

Pull Request for Issue #199 .

Summary of Changes

Added Postflight function and some language strings

Testing Instructions

On installation you should see more that the XML Description

167a01a 4 Apr 2020 avatar mtmeyrick #199
avatar mtmeyrick mtmeyrick - open - 4 Apr 2020
avatar richard67
richard67 - comment - 4 Apr 2020

And please fix code style errors reported by drone here: https://ci.joomla.org/joomla-extensions/patchtester/66/1/3

avatar richard67
richard67 - comment - 4 Apr 2020

@mtmeyrick Still not what I meant. I've made a pull request for you in your repository: mtmeyrick#1. Just use the "Merge" button on github in that PR, and this PR here will be fine.

avatar roland-d
roland-d - comment - 7 Apr 2020

First, thank you for the patch @mtmeyrick ?
Second, can you merge the master branch into your branch again, seems like you have some old files.
Third, I will review the PR now :)

avatar roland-d roland-d - change - 11 Apr 2020
Title
…
#199
Link to Patch Tester after installation #199
avatar roland-d roland-d - change - 11 Apr 2020
Title
…
#199
Link to Patch Tester after installation #199
avatar roland-d roland-d - edited - 11 Apr 2020
avatar roland-d roland-d - change - 11 Apr 2020
Title
…
Link to Patch Tester after installation #199
Link to Patch Tester after installation
avatar roland-d roland-d - change - 11 Apr 2020
Title
…
Link to Patch Tester after installation #199
Link to Patch Tester after installation
avatar roland-d roland-d - edited - 11 Apr 2020
avatar roland-d roland-d - reference | ed0c895 - 11 Apr 20
avatar roland-d roland-d - change - 11 Apr 2020
Milestone Added: 4.0.0
avatar roland-d
roland-d - comment - 12 Apr 2020

@mtmeyrick This branch now shows conflicts but they should be resolved once you merge my PR (mtmeyrick#2) against your branch.

avatar richard67
richard67 - comment - 12 Apr 2020

Looks good to me now.

Ping @roland-d Please just have a final look on the diff before merge in case I've missed something.

avatar roland-d roland-d - change - 12 Apr 2020
Status New ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-04-12 13:04:39
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 12 Apr 2020
avatar roland-d roland-d - merge - 12 Apr 2020
avatar roland-d roland-d - reference | b5dfe5d - 12 Apr 20
avatar roland-d roland-d - merge - 12 Apr 2020
avatar roland-d roland-d - close - 12 Apr 2020
avatar roland-d
roland-d - comment - 12 Apr 2020

Thanks everybody involved. This is now merged :) Happy Easter.

Add a Comment

Login with GitHub to post a comment