avatar conconnl
conconnl
4 Apr 2020

modified

avatar conconnl conconnl - open - 4 Apr 2020
avatar mtmeyrick
mtmeyrick - comment - 4 Apr 2020

Believe this has been the case in most if not all previous versions to be honest

avatar conconnl
conconnl - comment - 4 Apr 2020

Issue was created on request of Roland.

avatar richard67
richard67 - comment - 10 Apr 2020

@roland-d So the missing string is defined, but only in the com_patchtester.sys.ini language files, not in the com_patchtester.ini (without .sys) files. So 2 ways to go: Add the strings in the .sysfiles to the files without .sys, or always load the com_patchtester.sys.ini, too.

Let me know what you prefer or what's the right way.

I would prefer to add the 3 language strings in the .sys.ini to the .ini files, and that's it.

avatar richard67
richard67 - comment - 10 Apr 2020

@roland-d Ha, even better now: I see it is solved with PR #268 ;-)

avatar richard67
richard67 - comment - 10 Apr 2020

No, wait, it's the extensions update view I have to check.

avatar richard67
richard67 - comment - 10 Apr 2020

No, it's not solved with #268 .

avatar richard67
richard67 - comment - 10 Apr 2020

@roland-d @conconnl Am working on the solution. Stay tuned.

avatar richard67
richard67 - comment - 10 Apr 2020

@conconnl I've added the fix to my PR #268 . Please test. You can find a link to a patched patchtester package in that PR.

avatar roland-d roland-d - change - 11 Apr 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-04-11 19:53:05
Closed_By roland-d
avatar roland-d roland-d - close - 11 Apr 2020
avatar roland-d
roland-d - comment - 11 Apr 2020

Fixed with PR #268

Add a Comment

Login with GitHub to post a comment