avatar zero-24
zero-24
24 Apr 2017

Steps to reproduce the issue

https://travis-ci.org/joomla/jissues/jobs/225123398

Expected result

Green Travis

Actual result

Unhappy travis

Additional comments

FILE: ...ravis/build/joomla/jissues/cli/Application/Command/Export/Langfiles.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 5 | WARNING | Invalid year span "2012" found; consider "-2012" instead
 5 | ERROR   | A hyphen must be used between the earliest and latest year
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

But they are fine?
https://github.com/joomla/jissues/blob/master/cli/Application/Command/Export/Langfiles.php#L5

Or do they request us to use?

 @copyright  Copyright (C) 2012-2014 Open Source Matters, Inc. All rights reserved.
avatar zero-24 zero-24 - open - 24 Apr 2017
avatar mbabker
mbabker - comment - 24 Apr 2017

I would consider this an upstream issue between PHP_CodeSniffer or PHP core itself. Either PHP_CodeSniffer 1.x won't work with PHP 7.2 or there's been a B/C breaking change in 7.2 that affects PHP_CodeSniffer.

avatar b2z
b2z - comment - 24 Apr 2017

That's funny issue :)

avatar zero-24 zero-24 - change - 25 Apr 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-04-25 06:19:33
Closed_By zero-24
avatar zero-24 zero-24 - close - 25 Apr 2017
avatar zero-24
zero-24 - comment - 25 Apr 2017

Ok closing than as upstream issue. Thanks!

Add a Comment

Login with GitHub to post a comment