Feeling Lucky
[#963] - Return if we have no changed files
- Fixed in Code Base
- 1 May 2017
- Medium
- Build: master
- # 963
- Diff
- zero-24:iftherearenochanges
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Return if we have no changed files
Testing Instructions
mbabker
- | Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-01 18:49:23 |
| Closed_By | ⇒ | mbabker |
elkuku
- comment
- 6 May 2017
Hey,
I'm currently trying to find out why the category assigning thingy is failing.
I somehow missed this PR, so I'd like to shoot jut one simple question here:
If I'm not wrong the code in this PR checks if a PR has files.
I don't believe that this is necessary.
So - Why?
zero-24
- comment
- 6 May 2017
I don't believe that this is necessary.
This is correct. But this is a test if that is the issue.
should be like your suggestion now @b2z?