GitHub sync bug
avatar mbabker
mbabker
22 Oct 2016

See joomla/joomla-cms#12516

When I opened the PR, it correctly added the label. I pushed a couple of commits after I opened it then the label was removed. The language change is still there.

avatar mbabker mbabker - open - 22 Oct 2016
avatar zero-24
zero-24 - comment - 22 Oct 2016

can you check if you get any issues in the log about that issue / PR?

avatar zero-24
zero-24 - comment - 22 Oct 2016

Can you try a commit e.g a sync commit (this should trigger the bot) ;)

avatar zero-24
zero-24 - comment - 22 Oct 2016

errors like this: #893 maybe

avatar mbabker
mbabker - comment - 22 Oct 2016

There is nothing in the log, so it isn't erroring out. It is most assuredly removing the label though.

avatar zero-24
zero-24 - comment - 23 Oct 2016

Can you see what type of trigger is made? Maybe the got an empty pulls event triggerd if you change a description / title?

avatar mbabker
mbabker - comment - 23 Oct 2016

What do you mean "what type of trigger"? We don't have different types; it's just responding to a pull request webhook. What data is sent is the same regardless of the action taken, we just have different paths based on something being created and updated.

avatar zero-24
zero-24 - comment - 25 Oct 2016

The only thing i can think of that there was an empty hook where the files are empty.

avatar mbabker
mbabker - comment - 26 Oct 2016

joomla/joomla-cms#12532

I changed the title and the tests label was removed. Something is most assuredly not right here. Webhook payload - https://gist.github.com/mbabker/9848db88ac34d38636cabb8a5b1d1cb9

avatar elkuku
elkuku - comment - 26 Oct 2016

@zero24 if you could check that the CLI script isn't the culpable here...
That would be REALLY cool ;)

Am 25.10.2016 20:46 schrieb "zero-24" notifications@github.com:

The only thing i can think of that there was an empty hook where the files
are empty.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#898 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACEup9NQm4IjkGPLHsyjZK7IpsAkSbQks5q3k5-gaJpZM4Kd6Sv
.

avatar zero-24
zero-24 - comment - 26 Oct 2016

hmm can we add here: https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Hooks/Listeners/JoomlacmsPullsListener.php#L443 a check to be sure that we get the changed files from the pull request?

#902

avatar zero-24
zero-24 - comment - 26 Oct 2016

@elkuku i don't know how the CLI script is working but if i saw it correct it just runs the PR- label stuff?

avatar mbabker
mbabker - comment - 26 Oct 2016

The method is already logging errors if it doesn't pull the list of files (nothing in the logs for those errors and the loggers are configured to catch messages with a minimum level of "warning"). So since the API calls aren't failing, that would indicate the API is returning an empty response. And that's concerning if that indeed is the case.

avatar zero-24
zero-24 - comment - 26 Oct 2016

Is there a chance to get the content of the array so we can check?

avatar zero-24
zero-24 - comment - 30 Oct 2016

we have similiar issues here: https://issues.joomla.org/tracker/joomla-cms/12626 (the categories are not updated based on the last changes) for me it looks like a general problem.

IIRC we did not change much at that place in the past? So i guess that there is a problem with the github sync / webhook or there is a change? Can we see that there was a webhook on that pull request?

avatar mbabker
mbabker - comment - 30 Oct 2016

Anyone with admin access on the GitHub repos can view the webhook config and activity. https://github.com/joomla/joomla-cms/settings/hooks

avatar zero-24
zero-24 - comment - 30 Oct 2016

ok 404 for me but I'm also not sure if that would help me as i'm not sure that i understand this page.

avatar mbabker
mbabker - comment - 30 Oct 2016

If you can see that section you can see all of the configured webhooks for the repo, each sent webhook payload, and the response from the remote server.

avatar mbabker mbabker - change - 25 Nov 2016
Labels Added: bug GitHub sync
avatar mbabker mbabker - labeled - 25 Nov 2016
avatar mbabker mbabker - labeled - 25 Nov 2016
avatar mbabker
mbabker - comment - 27 Nov 2016

Looks fixed by f299982

avatar mbabker mbabker - change - 27 Nov 2016
The description was changed
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-11-27 21:11:35
Closed_By mbabker
avatar mbabker mbabker - close - 27 Nov 2016

Add a Comment

Login with GitHub to post a comment